Add London Support by joshuajbouw · Pull Request #54 · rust-ethereum/evm

joshuajbouw · 2021-08-19T09:02:26Z

This is a working branch for bringing London into the EVM.

In order to keep to do date with Ethereum upstream, we must actively keep up to date with its milestone updates. This is the hard fork following Berlin, and the London hard fork went live as of August 5th, 2021.

To track the progress of the ETH tests, go to the PR here: TODO!

NOTE: #40 must be merged in first!

Todo

Other EIPs relating to London are not relating to the evm.

This reverts commit bcffb19.

London: EIP-3529

…yed code (as opposed to the init code which generates the code to deploy) which starts with 0x3f; this also applies to all CREATE and CREATE2 calls (not just creation initiated from transactions directly)

joshuajbouw · 2021-09-28T05:49:38Z

@sorpaas this good to go?

sorpaas · 2021-09-28T17:37:14Z

Will do this soon. Sorry for the delay!

gakonst · 2021-10-16T08:05:02Z

@sorpaas anything we can do to help push this PR forward?

gakonst · 2021-10-19T15:13:11Z

@birchmd @joshuajbouw looks like the jsontests are fetched from master, think you'd need to checkout your branch here

birchmd · 2021-10-19T17:32:11Z

@birchmd @joshuajbouw looks like the jsontests are fetched from master, think you'd need to checkout your branch here

On previous breaking changes like (e.g. Berlin) this we've left it up to @sorpaas to run the tests locally and see they pass, without worrying too much about the GitHub checks. We could make the check smarter if desired, but as I understand it that is not holding up this PR. I hope @sorpaas will take a look at this PR soon and let us know if it can be merged.

Note: all tests do indeed pass if running this branch on rust-blockchain/evm-tests#8

sorpaas · 2021-10-27T14:03:29Z

This should not be fatal. Fatal is reserved for situations that the evm library cannot handle at all (trying to allocate memory more than 64-bit, for example) and it will abruptly exit all evm execution stack. In short, it's not a normal EVM semantics.

I believe you can just remove this since it is handled already by gasometer.

Done in 14b82b7

sorpaas · 2021-10-27T14:05:30Z

Just for eye candy -- I wonder if you can create a private struct DerivedValues and put the parameters inside that struct. It will be easier to extend in the future.

Done in cdb5a8c

sorpaas · 2021-10-27T14:13:45Z

This function seems to do two different things record_create_transaction_cost and initialize_with_access_list which I'm not certain is strictly related. I suggest we split it out and name them explicitly.

Done in 072d8bf

sorpaas

Looks mostly good to me but some grumbles.

sorpaas · 2021-10-27T14:14:41Z

Also please fix lints!

…se opcodes are validated before execution

birchmd · 2021-10-27T15:09:27Z

Thanks for the review @sorpaas ! I have addressed all the comments, please take another look.

sorpaas · 2021-10-27T15:36:45Z

Remove this line. fail is for Fatal and I don't think this is what we want here.

Ah sorry. I got this wrong. This is correct.

Done in 33d9e15

Sorry please revert this for now! We use gasometer.fail elsewhere in the same function for error/revert. They should be equivalent with or without, but let's keep it consistent and review the usage later in the future.

Reverted in 0b61849

This reverts commit 33d9e15.

…hereumTxEnvelope` (rust-ethereum#56) Recently added trait bounds to transaction types include `FromTxWithEncoded` as seen in rust-ethereum#54

rust-ethereum#54) feat: Add `FromTxWithEncoded` bound to `BlockExecutor` transaction This is to allow for empty envelopes

joshuajbouw and others added 19 commits August 10, 2021 18:27

Update minimum version of dependencies

bcffb19

add is_static back in

01e000c

Add in EIP-3541

124f69b

Merge branch 'feat/london/eip-3541' into feat/london-support

d663c1f

Initial work, requires EIP-1559

08cad4c

Add block_base_fee_per_gas to Backend trait

79f9a33

Merge branch 'feat/london/eip-3198' into feat/london-support

36b1bf8

Merge branch 'feat/london-support' into london-support-type-rollback

0aa3941

Add MAX_REFUND_QUOTIENT parameter

3c66240

Reduce SSTORE_CLEARS_SCHEDULE value

33737b6

Remove the SELFDESTRUCT refund.

6d2be2c

Avoid some runtime arithmetic

5251f48

Merge branch 'london-support-type-rollback' into feat/london-support

ede2398

Revert "Update minimum version of dependencies"

e576abd

This reverts commit bcffb19.

Merge pull request #3 from aurora-is-near/feat/london/eip-3529

01c2834

London: EIP-3529

Merge branch 'master' into feat/london-support

9ce2851

Fix: benches compilation

a9e0ac1

Fix(EIP-3541): the correct implementation is to deny the actual deplo…

8df12f0

…yed code (as opposed to the init code which generates the code to deploy) which starts with 0x3f; this also applies to all CREATE and CREATE2 calls (not just creation initiated from transactions directly)

Fix(EIP-1559): complete the implementation

a8caa20

birchmd mentioned this pull request Sep 9, 2021

Tests for London HF rust-blockchain/evm-tests#8

Merged

joshuajbouw marked this pull request as ready for review September 13, 2021 07:07

Merge branch 'master' into feat/london-support

e654235

Merge branch 'master' into feat/london-support

1afe7c5

birchmd added 2 commits October 27, 2021 15:49

Merge branch 'master' into feat/london-support

876d731

Fix benches build

81132c2

sorpaas reviewed Oct 27, 2021

View reviewed changes

birchmd added 4 commits October 27, 2021 16:47

cargo fmt

cef9bf4

Split up create_init function

072d8bf

Factor out inputs to config_with_derived_values as separate struct

cdb5a8c

Remove has_base_fee check from runtime system (it is not needed becau…

14b82b7

…se opcodes are validated before execution

sorpaas reviewed Oct 27, 2021

View reviewed changes

sorpaas approved these changes Oct 27, 2021

View reviewed changes

birchmd added 2 commits October 27, 2021 17:45

Remove gasometer fail

33d9e15

Revert "Remove gasometer fail"

0b61849

This reverts commit 33d9e15.

sorpaas merged commit 0fbde9f into rust-ethereum:master Oct 27, 2021

birchmd deleted the feat/london-support branch October 27, 2021 16:59

zjb0807 mentioned this pull request Dec 17, 2021

Update EVM config to take consideration on London hardforks AcalaNetwork/Acala#1693

Closed

balqaasem mentioned this pull request Jan 3, 2022

Support EVM London setheum/setheum#709

Closed

icodezjb mentioned this pull request May 6, 2022

Update Frontier/Ethereum/EVM to support Substrate v0.9.18 + EIP-1559 chainx-org/SherpaX#95

Merged

mattsse pushed a commit to mattsse/evm that referenced this pull request Jan 17, 2026

feat(tx): Add FromTxWithEncoded bound to BlockExecutor transaction (

74f1edf

rust-ethereum#54) feat: Add `FromTxWithEncoded` bound to `BlockExecutor` transaction This is to allow for empty envelopes

Conversation

joshuajbouw commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

joshuajbouw commented Sep 28, 2021

Uh oh!

sorpaas commented Sep 28, 2021

Uh oh!

gakonst commented Oct 16, 2021

Uh oh!

gakonst commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

birchmd commented Oct 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sorpaas left a comment

Choose a reason for hiding this comment

Uh oh!

sorpaas commented Oct 27, 2021

Uh oh!

birchmd commented Oct 27, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joshuajbouw commented Aug 19, 2021 •

edited

Loading

gakonst commented Oct 19, 2021 •

edited

Loading