London: EIP-3529#3
Merged
Merged
Conversation
birchmd
force-pushed
the
feat/london/eip-3529
branch
from
fe80309 to
bfccce1
Compare
birchmd
force-pushed
the
feat/london/eip-3529
branch
from
bfccce1 to
5251f48
Compare
birchmd
commented
Aug 25, 2021
Comment on lines
-42
to
-49
| let (gas_sstore_reset, gas_sload) = if config.increase_state_access_gas { | ||
| ( | ||
| config.gas_sstore_reset - config.gas_sload_cold, | ||
| config.gas_storage_read_warm, | ||
| ) | ||
| } else { | ||
| (config.gas_sstore_reset, config.gas_sload) | ||
| }; |
Member
Author
There was a problem hiding this comment.
I decided that doing this arithmetic at runtime was sub-optimal, so I pushed it into constructing the config itself with an addition const fn that takes some arguments. Computing these derived parameters at the level of constructing the config also makes the change to refund_sstore_clears in EIP-3529 cleaner.
mrLSD
approved these changes
Jun 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://eips.ethereum.org/EIPS/eip-3529