Berlin support#40
Conversation
This reverts commit d7ea767.
|
Can you merge master and do rustfmt again? Thank you! |
|
|
||
| /// Stack-based executor. | ||
| pub struct StackExecutor<'config, S> { | ||
| pub struct StackExecutor<'config, S: StackState<'config>, P: Precompiles<S>> { |
There was a problem hiding this comment.
What's the rationale for this change? One of the drawback of this is that it'll be potentially difficult for users to get a single type for StackExecutor suitable for different configurations of precompiles. Same reason why Config is not a generic parameter.
There was a problem hiding this comment.
That might've been an overzealous mistake there. I'll double check.
joshuajbouw
force-pushed
the
berlin-support
branch
from
2b60e2d to
7da1cbd
Compare
Co-authored-by: Wei Tang <accounts@that.world>
joshuajbouw
force-pushed
the
berlin-support
branch
from
7da1cbd to
d16bdec
Compare
joshuajbouw
force-pushed
the
berlin-support
branch
from
051ec20 to
a252024
Compare
|
Updated our nightly and we are getting benefits of reduced compile size and speed. So, going to keep it in. |
|
|
||
| impl<'config, S: StackState<'config>> StackExecutor<'config, S> { | ||
| /// Create a new stack-based executor. | ||
| pub fn new(state: S, config: &'config Config) -> Self { |
sorpaas
left a comment
sorpaas
left a comment
There was a problem hiding this comment.
LGTM mostly, but it would be great to add StackExecutor::new back.
3 participants
This PR adds both EIP-2929 and EIP-2930 into the EVM.
This is a key PR as it brings the necessary changes to get Berlin hard fork working with the EVM. Since this is a critical update, a discussion and review will be very welcomed. Do note that we will also be updating evm-tests as well to ensure full compatibility with Ethereum VM.
Others related to Berlin, EIP-2565 and EIP-2718, should be done on libraries implementing this change.