Fix download count to avoid ramdom fail on search_test#1498
Merged
Conversation
segiddins
reviewed
Nov 12, 2016
| setup { Rubygem.per_page = 2 } | ||
| setup do | ||
| 3.times do |i| | ||
| rubygem = create(:rubygem, name: "ruby#{i}", number: "1.#{i}.0") |
Contributor
There was a problem hiding this comment.
is changing the number necessary?
Member
There was a problem hiding this comment.
number creates corresponding version. Our query condition has versions.indexed and without version response will always be empty.
I would suggest not to use number: "1.#{i}.0" and let it be number: "1.0.0". Someone may try to read into need of different version number when there is none.
Contributor
Author
There was a problem hiding this comment.
Yes its useless that was my first guess but I forget to remove it
spk
force-pushed
the
fix-ramdomly-fail-search_test
branch
from
3ace60b to
83a3d0b
Compare
Contributor
Author
|
@segiddins @sonalkr132 updated and added 9703fe9 |
4 tasks
Contributor
|
@homu r+ |
Contributor
|
📌 Commit 9703fe9 has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Nov 14, 2016
Fix download count to avoid ramdom fail on search_test ref c052833 see https://github.com/spk/rubygems.org/blob/c346b910db404bad1ff209266e4ebd740a5a22b0/app/models/concerns/rubygem_searchable.rb#L138 Fix #1497
homu
added a commit
that referenced
this pull request
Dec 28, 2016
Expose rubygem reverse depencencies  - [x] rebase after #1498 merged - [x] Fix rubocop on rubygem_helper class - [x] Extract aside template - [x] Improve reverse deps queries, (ref #1508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref c052833
see https://github.com/spk/rubygems.org/blob/c346b910db404bad1ff209266e4ebd740a5a22b0/app/models/concerns/rubygem_searchable.rb#L138
Fix #1497