Expose rubygem reverse depencencies by spk · Pull Request #945 · rubygems/rubygems.org

spk · 2015-04-29T17:20:44Z

rebase after Fix download count to avoid ramdom fail on search_test #1498 merged
Fix rubocop on rubygem_helper class
Extract aside template
Improve reverse deps queries, (ref Version.reverse_dependencies perfomance #1508)

dwradcliffe · 2015-04-29T17:32:46Z

Can you post a screenshot?

spk · 2015-04-29T17:40:40Z

@dwradcliffe yes it's on the description

francois2metz · 2015-04-29T19:27:47Z

<3

sferik · 2015-04-29T20:45:24Z

As the maintainer of many gems, this information is incredibly useful to me—knowing which gems depend on mine, so I can see how they’re being used—but I remember when we benchmarked this query it was rather slow. Since this information is not broadly useful (to 99% of gem users vs. 1% of gem maintainers), it may make more sense to put on a separate page, so the query doesn’t need to run every time someone looks at a gem page.

Also, have you tested that this will work on specific gem version pages? For example if gem a depends on gem b ~> 1.0, gem a should appear as a reverse dependency for gem b version 1.0.0 and 1.9.9, but not 0.9.9 or 2.0.0. There may already be unit tests for this case but I’d feel better if we had functional/controller tests covering it.

spk · 2015-04-30T13:02:40Z

I see what you mean @sferik, and I did not try with the production database.
I will work on a separate page version, with versions selection.
Thank you for the feedback.

sferik · 2015-04-30T13:27:47Z

@spk 👍 Thank you for working on this feature. I’m really looking forward to the day when it’s merged and deployed.

spk · 2015-05-01T08:12:24Z

With latest production database, with rails the query is about 151.6ms and give 8073 reverse dependencies to rails gem!
So yes another page with version and pagination is required!

simi · 2015-05-01T12:00:22Z

Maybe it will be handy to sort gems by download count.

spk · 2015-05-02T19:04:04Z

I think I have a usable feature, with pagination, search filter and ordered by download (thanks @simi).
For versions I'm using the same method as in the API, but it don't filter with major/minor version @sferik.

parndt · 2015-05-10T22:49:06Z

As a gem maintainer, this is a really helpful feature.. thank you!

spk · 2015-05-11T07:40:18Z

Thanks! Is it possible to have a review by the team and get it merge ?

sferik · 2015-05-11T08:58:47Z

👍 Looks good to me. I’d like to see a 👍 from at least one other maintainer before merging.

/cc @qrush @evanphx @skottler @dwradcliffe

qrush · 2015-05-11T13:00:21Z

A few comments-

I feel this would been cleaner implemented as ReverseDependenciesController - anything that isn't a RESTful action tends to be a smell, eventually. That can wait for a refactoring PR if anyone is up for it.
The HTML view is pretty barebones. Can we show the same partial as on searches#show, and possibly get that cached?
We'll have to watch performance a little more carefully when this is deployed - at least paginating it helps.

simi · 2015-05-11T13:05:36Z

I'm going to review this today.

spk · 2015-07-02T18:39:24Z

Status since last review:

Performance issue fixed by 3e13be0
Nicer templates using existing and share aside sidebar

oz · 2015-07-05T11:11:16Z

This would be a nice feature. I hope you guys find time to merge this. 👍

qrush · 2015-07-07T03:14:44Z

Is there any way we can get this on a "feature flag" type system? So if we deploy it and need to turn it off fast w/o rollback that would be feasible. Any thoughts @dwradcliffe @arthurnn ?

dwradcliffe · 2015-07-07T12:14:18Z

@qrush good idea 👍

arthurnn · 2015-07-08T14:00:34Z

"feature flag" , should be easy to make it work. 👍 from me.. the only thing I hate about those is that people tend to leave features behind, and the code start getting 2+ code paths.. As long as we remember that. I am fine

bf4 · 2015-07-17T01:10:40Z

Great job! These pages would definitely need to be throttled so someone couldn't use it to DDoS the site ;) That is, they should have a default/fallback state of 'unavailable' at this time when the data is not available, for whatever reason.

Also, any consideration to do this in JavaScript via the API, perhaps like gemloupe did? (bookmarklet below)

javascript:(function(){var script=document.createElement('SCRIPT');script.src='https://www.gemlou.pe/assets/remote_loupe_consumer.js';document.body.appendChild(script);})()

I'd be happy to do the JS as an Ember Component

sonalkr132 · 2016-11-21T17:08:56Z

@spk I have bad news 😓

It has n+1 for gem_download. Also, Versions.reverse_dependencies(name) is too effin slow 😭

  def self.reverse_dependencies(name)
    joins(dependencies: :rubygem)
      .indexed
      .where(rubygems: { name: name })
  end

I think first finding the gem and then using id instead of name would be way faster. Do you think you can benchmark two options and open an issue?

spk · 2016-11-21T17:37:07Z

@sonalkr132 not that bad !
For the record those methods are already used on the API
I can work on that maybe later this week

sonalkr132 · 2016-11-21T19:07:58Z

I can work on that maybe later this week

Sure 👍

kbrock · 2016-11-22T16:33:07Z

not sure if this needs an index. And does this want to be case insensitive? (use lower)

sonalkr132 · 2016-12-17T18:28:50Z

+  before_action :set_page, only: [:index]
+
+  def index
+    @latest_version = @rubygem.versions.most_recent


Isn't @latest_version already set with before_action :latest_version?

Yes its a mistake; fixed in 61a5a90

sonalkr132 · 2016-12-17T18:29:46Z

+<header class="gems__header push">
+  <%= form_tag rubygem_reverse_dependencies_path(@rubygem),
+    :id => "rdeps-search", :class => "header__search-wrap", :method => :get do %>
+    <%= search_field_tag :rdeps_query, params[:rdeps_query], :placeholder => "Search Reverse Deps Gems&hellip;".html_safe, :class => "header__search" %>


Please use I18n for placeholder.

Fixed in 5ef01ec

sonalkr132 · 2016-12-17T18:30:31Z

+    :id => "rdeps-search", :class => "header__search-wrap", :method => :get do %>
+    <%= search_field_tag :rdeps_query, params[:rdeps_query], :placeholder => "Search Reverse Deps Gems&hellip;".html_safe, :class => "header__search" %>
+    <%= label_tag :rdeps_query do %>
+      <span class="t-hidden">Search gems</span>


Please use I18n.

Fixed in 5ef01ec

sonalkr132 · 2016-12-21T11:01:00Z

+  before_action :set_page, only: [:index]
+
+  def index
+    @reverse_dependencies = @rubygem.reverse_dependencies.by_downloads


Please use @rubygem.reverse_dependencies.by_downloads.includes(:latest_version, :gem_download) instead.

see 012c1e2

sonalkr132 · 2016-12-21T11:02:42Z

@@ -0,0 +1,12 @@
+<header class="gems__header push">
+  <%= form_tag rubygem_reverse_dependencies_path(@rubygem),
+    :id => "rdeps-search", :class => "header__search-wrap", :method => :get do %>


Please use ruby 1.9 hash syntax.

see fa0f34b

* /gems/:rubygem_id/reverse_dependencies * search on reverse dependencies

@sonalkr132

Thanks-to: @sonalkr132

indirect · 2016-12-28T21:21:07Z

@homu r+

homu · 2016-12-28T21:21:08Z

📌 Commit 012c1e2 has been approved by indirect

Expose rubygem reverse depencencies ![rails_reverse_dependencies_search_jquery](https://cloud.githubusercontent.com/assets/98590/7667144/605ee3a4-fbfe-11e4-94ae-6d71442aa5a5.png) - [x] rebase after #1498 merged - [x] Fix rubocop on rubygem_helper class - [x] Extract aside template - [x] Improve reverse deps queries, (ref #1508)

homu · 2016-12-28T21:21:22Z

⌛ Testing commit 012c1e2 with merge 9769a74...

homu · 2016-12-28T21:26:04Z

☀️ Test successful - status

spk force-pushed the expose-reverse-dependencies branch from 9fcb184 to 5515976 Compare May 3, 2015 08:57

spk force-pushed the expose-reverse-dependencies branch 2 times, most recently from 95dd967 to 70c25b3 Compare May 17, 2015 12:53

spk force-pushed the expose-reverse-dependencies branch from 70c25b3 to 76fa2e9 Compare May 23, 2015 10:43

spk force-pushed the expose-reverse-dependencies branch from 76fa2e9 to 324918d Compare June 16, 2015 21:32

spk force-pushed the expose-reverse-dependencies branch from 324918d to 2acaddb Compare July 2, 2015 18:16

qrush mentioned this pull request Jul 7, 2015

Full gem dependencies tree (can be as separate view) #937

Closed

spk force-pushed the expose-reverse-dependencies branch 3 times, most recently from 14cea47 to 4a54ddc Compare July 15, 2015 19:52

spk force-pushed the expose-reverse-dependencies branch from 53b651c to fc5785e Compare November 20, 2016 17:51

spk mentioned this pull request Nov 27, 2016

Version.reverse_dependencies perfomance #1508

Closed

spk force-pushed the expose-reverse-dependencies branch from 3f7b4eb to 4a48e62 Compare December 5, 2016 19:22

sonalkr132 reviewed Dec 17, 2016

View reviewed changes

spk force-pushed the expose-reverse-dependencies branch from 4a48e62 to 5ef01ec Compare December 18, 2016 17:42

sonalkr132 reviewed Dec 21, 2016

View reviewed changes

spk added 3 commits December 21, 2016 18:53

Expose rubygem reverse depencencies

fa8ab20

* /gems/:rubygem_id/reverse_dependencies * search on reverse dependencies

Remove duplicate @latest_version load

2cd4e19

Use I18n for search reverse deps input

2a25ff4

spk force-pushed the expose-reverse-dependencies branch from 5ef01ec to 2a25ff4 Compare December 21, 2016 17:53

spk added 2 commits December 21, 2016 18:56

Use Ruby 1.9 hash syntax for _reverse_dependencies.html

fa0f34b

Include latest_version and gem_download for reverse

012c1e2

Thanks-to: @sonalkr132

sonalkr132 approved these changes Dec 22, 2016

View reviewed changes

homu merged commit 012c1e2 into rubygems:master Dec 28, 2016

This was referenced Dec 28, 2016

Leverage metadata to populate gems urls v2 #1234

Merged

Leverage metadata to populate gems urls #724

Closed

Cleaning up locale files and enforcing consistency #1522

Merged

spk deleted the expose-reverse-dependencies branch January 10, 2017 09:06

Uh oh!

Conversation

spk commented Apr 29, 2015 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dwradcliffe commented Apr 29, 2015

Uh oh!

spk commented Apr 29, 2015

Uh oh!

francois2metz commented Apr 29, 2015

Uh oh!

sferik commented Apr 29, 2015

Uh oh!

spk commented Apr 30, 2015

Uh oh!

sferik commented Apr 30, 2015

Uh oh!

spk commented May 1, 2015

Uh oh!

simi commented May 1, 2015

Uh oh!

spk commented May 2, 2015

Uh oh!

parndt commented May 10, 2015

Uh oh!

spk commented May 11, 2015

Uh oh!

sferik commented May 11, 2015

Uh oh!

qrush commented May 11, 2015

Uh oh!

simi commented May 11, 2015

Uh oh!

spk commented Jul 2, 2015

Uh oh!

oz commented Jul 5, 2015

Uh oh!

qrush commented Jul 7, 2015

Uh oh!

dwradcliffe commented Jul 7, 2015

Uh oh!

arthurnn commented Jul 8, 2015

Uh oh!

bf4 commented Jul 17, 2015

Uh oh!

sonalkr132 commented Nov 21, 2016

Uh oh!

spk commented Nov 21, 2016

Uh oh!

sonalkr132 commented Nov 21, 2016

Uh oh!

kbrock commented Nov 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

indirect commented Dec 28, 2016

Uh oh!

homu commented Dec 28, 2016

Uh oh!

homu commented Dec 28, 2016

Uh oh!

homu commented Dec 28, 2016

spk commented Apr 29, 2015 •

edited

Loading