Skip to content

Fix download count to avoid ramdom fail on search_test #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
homu merged 2 commits into from
Nov 14, 2016
Merged

Fix download count to avoid ramdom fail on search_test #1498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a3d0b
Fix download count to avoid ramdom fail on search_test
spk Nov 12, 2016
9703fe9
Improve search_test refute content ruby0
spk Nov 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/integration/search_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,18 @@ class SearchTest < SystemTest
end
end

setup { Rubygem.per_page = 2 }
setup do
3.times do |i|
rubygem = create(:rubygem, name: "ruby#{i}", number: '1.0.0')
rubygem.gem_download.update(count: i)
end
Rubygem.per_page = 2
end
teardown { Rubygem.per_page = 30 }

test "params has non white listed keys" do
(1..3).map { |i| create(:rubygem, name: "ruby#{i}", number: '1.0.0') }
visit '/search?query=ruby&script_name=javascript:alert(1)//'
refute page.has_content? "ruby0"
assert page.has_content? "ruby1"
assert page.has_content? "ruby2"
assert page.has_link?("Next", href: "/search?page=2&query=ruby")
Expand Down