Skip to content

Rename ruby_version to required_ruby_version#1294

Merged
dwradcliffe merged 2 commits into
rubygems:masterfrom
sonalkr132:require_ruby_version
May 29, 2016
Merged

Rename ruby_version to required_ruby_version#1294
dwradcliffe merged 2 commits into
rubygems:masterfrom
sonalkr132:require_ruby_version

Conversation

@sonalkr132
Copy link
Copy Markdown
Member

So that it better reflects what it has stored.
endpoints/api has not changed. They still use ruby_version.

@dwradcliffe
Copy link
Copy Markdown
Member

👍

@sonalkr132
Copy link
Copy Markdown
Member Author

sonalkr132 commented May 27, 2016

@dwradcliffe wouldn't it be a problem if this line is changed, out of order(chronologically)? My last two PRs change it too.

@homu
Copy link
Copy Markdown
Contributor

homu commented May 28, 2016

☔ The latest upstream changes (presumably #1293) made this pull request unmergeable. Please resolve the merge conflicts.

@sonalkr132 sonalkr132 force-pushed the require_ruby_version branch from 076cf18 to a65c2a2 Compare May 28, 2016 06:49
@dwradcliffe dwradcliffe merged commit ab43864 into rubygems:master May 29, 2016
@dwradcliffe dwradcliffe temporarily deployed to staging May 29, 2016 02:18 Inactive
@dwradcliffe dwradcliffe temporarily deployed to production May 31, 2016 13:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants