Remove rubygems download#1292
Merged
dwradcliffe merged 2 commits intoMay 29, 2016
Merged
Conversation
| add_index "users", ["remember_token"], name: "index_users_on_remember_token", using: :btree | ||
| add_index "users", ["token"], name: "index_users_on_token", using: :btree | ||
|
|
||
| create_table "version_histories", force: :cascade do |t| |
Member
Author
There was a problem hiding this comment.
Sorry about this. In #1285 I had forgotten to run the migration 😭
Contributor
|
☔ The latest upstream changes (presumably #1293) made this pull request unmergeable. Please resolve the merge conflicts. |
sonalkr132
force-pushed
the
remove_rubygems_download
branch
from
1ed212a to
e680e87
Compare
Contributor
|
☔ The latest upstream changes (presumably #1294) made this pull request unmergeable. Please resolve the merge conflicts. |
Rubygems has downloads method which used gem_downloads' count. Add `downloads` as transient attribute of Rubygem.
sonalkr132
force-pushed
the
remove_rubygems_download
branch
from
e680e87 to
d80b82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using GemDownload for all purposes now.
A lot of tests broke after I removed
downloadswith error:Since we had used
create(rubygems, ...., downloads: some_number)quite a few places, I addeddownloadsas transient attribute ofrubygemfactory to avoid making too many changes and to keep tests DRY.