[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section …#6697
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
|
rubygems link in changelog_uri was introduced by https://github.com/rubygems/rubygems.org/pull/1553/files |
greysteil
left a comment
There was a problem hiding this comment.
Makes a lot of sense to me - thanks for the contribution! I'll leave open for 24 hours for others to chime in on, and merge if no-one has any other feedback.
|
oh. I'll try to fix test. |
|
@walf443 Thanks. I will merge this after test passes. |
bbda404 to
e6a64de
Compare
e6a64de to
f78645d
Compare
|
@hsbt I'm sorry to be late to fix test. |
|
@bundlerbot r+ |
|
📌 Commit f78645d has been approved by |
[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section … ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add CHANGELOG.md when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem. ### What is your fix for the problem, implemented in this PR? My fix is only added metadata[:changelog_uri] to generated gemspec file. Changelog.md file is not generated by default. ### Why did you choose this fix out of the possible options? I chose this fix because Changelog.md file format is different by projects.
|
☀️ Test successful - status-travis |
[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section … ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add CHANGELOG.md when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem. ### What is your fix for the problem, implemented in this PR? My fix is only added metadata[:changelog_uri] to generated gemspec file. Changelog.md file is not generated by default. ### Why did you choose this fix out of the possible options? I chose this fix because Changelog.md file format is different by projects. (cherry picked from commit c7ed6a2)
[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section … ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add CHANGELOG.md when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem. ### What is your fix for the problem, implemented in this PR? My fix is only added metadata[:changelog_uri] to generated gemspec file. Changelog.md file is not generated by default. ### Why did you choose this fix out of the possible options? I chose this fix because Changelog.md file format is different by projects. (cherry picked from commit c7ed6a2)
* 1-16-stable: Version 1.16.6 with changelog fix uninitialized @use_gvp instance var warning no longer test Ruby 1.9.3 against rubygems master Merge #6708 Auto merge of #6697 - walf443:added_changelog_section, r=hsbt Merge #6687 Merge #6686 Auto merge of #6670 - bundler:colby/invite-stephanie-morillo, r=segiddins Auto merge of #6627 - agrim123:agr-fix-add-groups, r=deivid-rodriguez Auto merge of #6612 - hdf1986:readme-bundle-add, r=segiddins Auto merge of #6495 - bundler:segiddins/6491-extra-gem-platform-in-lockfile, r=segiddins Auto merge of #6493 - agrim123:agr-update-bundle-update-docs, r=colby-swandale Auto merge of #6310 - utilum:rescue_unspecified_exception, r=segiddins Auto merge of #6184 - arbonap:pa-check-in-gemfile-docs, r=indirect fix typo
|
@walf443 Thank you so much for putting together this PR. /cc @olivierlacan not sure if you saw this |
|
@kbrock I did in a new gem I built. It's awesome! Although I was a bit confused that the block appeared wrapped in the RubyGems.org push prevention conditional at first because of the comment location. Seems like that might confuse some folks into deleting the whole conditional block: # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
# to allow pushing to a single host or delete this section to allow pushing to any host.
if spec.respond_to?(:metadata)
spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"
spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
else
raise "RubyGems 2.0 or newer is required to protect against " \
"public gem pushes."
endI think I might submit a PR to address that if it makes sense. Edit: Looks like @deivid-rodriguez's already taken care of that in 6a0da62. Thanks Deivid! |
What was the end-user problem that led to this PR?
The problem was I always have to remember how to add CHANGELOG.md when I set up a new gem.
What was your diagnosis of the problem?
My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem.
What is your fix for the problem, implemented in this PR?
My fix is only added metadata[:changelog_uri] to generated gemspec file.
Changelog.md file is not generated by default.
Why did you choose this fix out of the possible options?
I chose this fix because Changelog.md file format is different by projects.