This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[Definition] Filter out unneeded gem platforms after resolving#6495
Merged
bundlerbot merged 1 commit intomasterfrom Jul 22, 2018
Merged
[Definition] Filter out unneeded gem platforms after resolving#6495bundlerbot merged 1 commit intomasterfrom
bundlerbot merged 1 commit intomasterfrom
Conversation
segiddins
force-pushed
the
segiddins/6491-extra-gem-platform-in-lockfile
branch
from
4029a98 to
e2e8e5a
Compare
Contributor
Author
|
@indirect please review ? |
|
Any updates on this? Is this PR merge-ready? |
Contributor
Author
|
It’s just awaiting review |
deivid-rodriguez
approved these changes
Jul 22, 2018
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Looks great to me!
|
|
||
| def platforms_for_dependency_named(dependency) | ||
| __dependencies.select {|_, deps| deps.map(&:name).include? dependency }.keys | ||
| end |
Contributor
There was a problem hiding this comment.
This was just dead code not meant to be used inside or outside of bundler... right?
Contributor
Author
|
@bundlerbot r+ |
Collaborator
|
📌 Commit e2e8e5a has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jul 22, 2018
…ckfile, r=segiddins [Definition] Filter out unneeded gem platforms after resolving ### What was the end-user problem that led to this PR? The problem was the lockfile would contain platform-specific gems that it didn't need Closes #6491 ### What was your diagnosis of the problem? My diagnosis was the resolver sometimes activates platforms it doesn't need, since it can't know it won't need them ### What is your fix for the problem, implemented in this PR? My fix is to use `SpecSet#for` to filter out gems that won't ever be used ### Why did you choose this fix out of the possible options? I chose this fix because it isn't re-inventing the wheel!
Collaborator
|
☀️ Test successful - status-travis |
deivid-rodriguez
deleted the
segiddins/6491-extra-gem-platform-in-lockfile
branch
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
…ckfile, r=segiddins [Definition] Filter out unneeded gem platforms after resolving ### What was the end-user problem that led to this PR? The problem was the lockfile would contain platform-specific gems that it didn't need Closes #6491 ### What was your diagnosis of the problem? My diagnosis was the resolver sometimes activates platforms it doesn't need, since it can't know it won't need them ### What is your fix for the problem, implemented in this PR? My fix is to use `SpecSet#for` to filter out gems that won't ever be used ### Why did you choose this fix out of the possible options? I chose this fix because it isn't re-inventing the wheel! (cherry picked from commit 7b603f3)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
…ckfile, r=segiddins [Definition] Filter out unneeded gem platforms after resolving ### What was the end-user problem that led to this PR? The problem was the lockfile would contain platform-specific gems that it didn't need Closes #6491 ### What was your diagnosis of the problem? My diagnosis was the resolver sometimes activates platforms it doesn't need, since it can't know it won't need them ### What is your fix for the problem, implemented in this PR? My fix is to use `SpecSet#for` to filter out gems that won't ever be used ### Why did you choose this fix out of the possible options? I chose this fix because it isn't re-inventing the wheel! (cherry picked from commit 7b603f3)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 7, 2018
* 1-16-stable: Version 1.16.6 with changelog fix uninitialized @use_gvp instance var warning no longer test Ruby 1.9.3 against rubygems master Merge #6708 Auto merge of #6697 - walf443:added_changelog_section, r=hsbt Merge #6687 Merge #6686 Auto merge of #6670 - bundler:colby/invite-stephanie-morillo, r=segiddins Auto merge of #6627 - agrim123:agr-fix-add-groups, r=deivid-rodriguez Auto merge of #6612 - hdf1986:readme-bundle-add, r=segiddins Auto merge of #6495 - bundler:segiddins/6491-extra-gem-platform-in-lockfile, r=segiddins Auto merge of #6493 - agrim123:agr-update-bundle-update-docs, r=colby-swandale Auto merge of #6310 - utilum:rescue_unspecified_exception, r=segiddins Auto merge of #6184 - arbonap:pa-check-in-gemfile-docs, r=indirect fix typo
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was the lockfile would contain platform-specific gems that it didn't need
Closes #6491
What was your diagnosis of the problem?
My diagnosis was the resolver sometimes activates platforms it doesn't need, since it can't know it won't need them
What is your fix for the problem, implemented in this PR?
My fix is to use
SpecSet#forto filter out gems that won't ever be usedWhy did you choose this fix out of the possible options?
I chose this fix because it isn't re-inventing the wheel!