Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Updated 'bundle add' to rspec install guide#6612

Merged
bundlerbot merged 1 commit intorubygems:masterfrom
hdf1996:readme-bundle-add
Jul 1, 2018
Merged

Updated 'bundle add' to rspec install guide#6612
bundlerbot merged 1 commit intorubygems:masterfrom
hdf1996:readme-bundle-add

Conversation

@hdf1996
Copy link
Copy Markdown
Contributor

@hdf1996 hdf1996 commented Jun 30, 2018

What was the end-user problem that led to this PR?

There's a new command bundle add which is almost unknown

What was your diagnosis of the problem?

We are promoting to use a simple append to the Gemfile when there's a bundle add command available

What is your fix for the problem, implemented in this PR?

My fix is just a little readme change 😅

Why did you choose this fix out of the possible options?

Because it's a simple fix and provides more exposure to the command

@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@hdf1996 hdf1996 force-pushed the readme-bundle-add branch from d0365bf to 72da6e6 Compare June 30, 2018 16:08
@hdf1996 hdf1996 changed the title Updated 'bundle add' to rspec install gudie Updated 'bundle add' to rspec install guide Jun 30, 2018
@segiddins
Copy link
Copy Markdown
Contributor

Awesome, thanks!

@bundlerbot r+

@bundlerbot
Copy link
Copy Markdown
Collaborator

📌 Commit 72da6e6 has been approved by segiddins

@bundlerbot
Copy link
Copy Markdown
Collaborator

⌛ Testing commit 72da6e6 with merge 34f909f...

bundlerbot added a commit that referenced this pull request Jul 1, 2018
Updated 'bundle add' to rspec install guide

### What was the end-user problem that led to this PR?

There's a new command `bundle add` which is almost unknown

### What was your diagnosis of the problem?

We are promoting to use a simple append to the Gemfile when there's a `bundle add` command available

### What is your fix for the problem, implemented in this PR?

My fix is just a little readme change 😅

### Why did you choose this fix out of the possible options?

Because it's a simple fix and provides more exposure to the command
@bundlerbot
Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
Approved by: segiddins
Pushing 34f909f to master...

@bundlerbot bundlerbot merged commit 72da6e6 into rubygems:master Jul 1, 2018
@hdf1996 hdf1996 deleted the readme-bundle-add branch July 1, 2018 15:52
@colby-swandale colby-swandale added this to the 1.17.1 milestone Sep 24, 2018
colby-swandale pushed a commit that referenced this pull request Oct 5, 2018
Updated 'bundle add' to rspec install guide

### What was the end-user problem that led to this PR?

There's a new command `bundle add` which is almost unknown

### What was your diagnosis of the problem?

We are promoting to use a simple append to the Gemfile when there's a `bundle add` command available

### What is your fix for the problem, implemented in this PR?

My fix is just a little readme change 😅

### Why did you choose this fix out of the possible options?

Because it's a simple fix and provides more exposure to the command

(cherry picked from commit 34f909f)
colby-swandale pushed a commit that referenced this pull request Oct 5, 2018
Updated 'bundle add' to rspec install guide

### What was the end-user problem that led to this PR?

There's a new command `bundle add` which is almost unknown

### What was your diagnosis of the problem?

We are promoting to use a simple append to the Gemfile when there's a `bundle add` command available

### What is your fix for the problem, implemented in this PR?

My fix is just a little readme change 😅

### Why did you choose this fix out of the possible options?

Because it's a simple fix and provides more exposure to the command

(cherry picked from commit 34f909f)
colby-swandale pushed a commit that referenced this pull request Oct 7, 2018
* 1-16-stable:
  Version 1.16.6 with changelog
  fix uninitialized @use_gvp instance var warning
  no longer test Ruby 1.9.3 against rubygems master
  Merge #6708
  Auto merge of #6697 - walf443:added_changelog_section, r=hsbt
  Merge #6687
  Merge #6686
  Auto merge of #6670 - bundler:colby/invite-stephanie-morillo, r=segiddins
  Auto merge of #6627 - agrim123:agr-fix-add-groups, r=deivid-rodriguez
  Auto merge of #6612 - hdf1986:readme-bundle-add, r=segiddins
  Auto merge of #6495 - bundler:segiddins/6491-extra-gem-platform-in-lockfile, r=segiddins
  Auto merge of #6493 - agrim123:agr-update-bundle-update-docs, r=colby-swandale
  Auto merge of #6310 - utilum:rescue_unspecified_exception, r=segiddins
  Auto merge of #6184 - arbonap:pa-check-in-gemfile-docs, r=indirect
  fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants