This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Make Bundler.setup not make Kernel#gem public in Bundler 2#5838
Merged
bundlerbot merged 1 commit intomasterfrom Jul 9, 2017
Merged
Make Bundler.setup not make Kernel#gem public in Bundler 2#5838bundlerbot merged 1 commit intomasterfrom
bundlerbot merged 1 commit intomasterfrom
Conversation
Collaborator
|
☔ The latest upstream changes (presumably #5839) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
seg-make-gem-private
branch
from
5239b8e to
b7387ed
Compare
|
awesome. @bundlerbot r+ |
Collaborator
|
📌 Commit b7387ed has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jul 8, 2017
Make Bundler.setup not make Kernel#gem public in Bundler 2 ### What was the end-user problem that led to this PR? The problem was Bundler 1 accidentally made `Kernel#gem` public, even though RubyGems declares it as private. Oops. We tried to make it private in 1.13, it broke stuff, so we added in a hack to keep it public. ### What was your diagnosis of the problem? My diagnosis was we could delete that hack in 2.0. ### What is your fix for the problem, implemented in this PR? My fix implements a feature flag that skips making `Kernel#gem` public, and adds regression tests for `gem` or `require` accidentally being made public.
Collaborator
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was Bundler 1 accidentally made
Kernel#gempublic, even though RubyGems declares it as private. Oops. We tried to make it private in 1.13, it broke stuff, so we added in a hack to keep it public.What was your diagnosis of the problem?
My diagnosis was we could delete that hack in 2.0.
What is your fix for the problem, implemented in this PR?
My fix implements a feature flag that skips making
Kernel#gempublic, and adds regression tests forgemorrequireaccidentally being made public.