This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] Add a global cache for downloaded .gem files#5782
Merged
bundlerbot merged 6 commits intomasterfrom Jun 27, 2017
Merged
Conversation
segiddins
requested review from
colby-swandale and
indirect
and removed request for
indirect
|
This is looking great to me. Very excited about using |
segiddins
force-pushed
the
seg-global-gem-cache
branch
from
0fabbd2 to
6f8c0d9
Compare
Contributor
Author
|
Green. Is there anything else I missed in #3983 that's relevant? (I think there were some commits related to other changes that made that diff needlessly large) |
|
@bundlerbot r+ |
Collaborator
|
📌 Commit 6f8c0d9 has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 22, 2017
[2.0] Add a global cache for downloaded .gem files ### What was the end-user problem that led to this PR? The problem was that bundler would need to download `foo-1.0.gem` files from a RubyGems server for each different ruby version installed on a user's machine. It also meant that people installing into a per-app path would need to re-download every gem for that bundle an additional time. This adds up, and makes `bundle install` slower than it needs to be. ### Was was your diagnosis of the problem? My diagnosis was that Bundler could keep a (per-source) cache of these `.gem` files, and pull from that cache instead of hitting the network whenever possible. ### What is your fix for the problem, implemented in this PR? My fix implements said cache, in a very similar way to the compact index cache (same cache slug per remote strategy, etc). This largely comes from #3983. ### Why did you choose this fix out of the possible options? I chose this fix because it is safe when used from multi-source gemfiles, it is easy to clear (`rm -rf bundle cache`), and it minimally interferes with the existing installation process.
|
(gonna export the env for this and run from master on my machine until this is released, now) |
Contributor
Author
|
@indirect |
Contributor
Author
|
Ugh has this timed out on CI? |
Contributor
Author
|
@bundlerbot retry |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 22, 2017
[2.0] Add a global cache for downloaded .gem files ### What was the end-user problem that led to this PR? The problem was that bundler would need to download `foo-1.0.gem` files from a RubyGems server for each different ruby version installed on a user's machine. It also meant that people installing into a per-app path would need to re-download every gem for that bundle an additional time. This adds up, and makes `bundle install` slower than it needs to be. ### Was was your diagnosis of the problem? My diagnosis was that Bundler could keep a (per-source) cache of these `.gem` files, and pull from that cache instead of hitting the network whenever possible. ### What is your fix for the problem, implemented in this PR? My fix implements said cache, in a very similar way to the compact index cache (same cache slug per remote strategy, etc). This largely comes from #3983. ### Why did you choose this fix out of the possible options? I chose this fix because it is safe when used from multi-source gemfiles, it is easy to clear (`rm -rf bundle cache`), and it minimally interferes with the existing installation process.
Collaborator
|
💔 Test failed - status-travis |
Contributor
Author
|
@bundlerbot retry |
Collaborator
|
☔ The latest upstream changes (presumably #5788) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
🔒 Merge conflict |
segiddins
force-pushed
the
seg-global-gem-cache
branch
from
6f8c0d9 to
1c8b0f6
Compare
Contributor
Author
|
Rebased. @bundlerbot r=indirect |
Collaborator
|
📌 Commit 1c8b0f6 has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Jun 27, 2017
[2.0] Add a global cache for downloaded .gem files ### What was the end-user problem that led to this PR? The problem was that bundler would need to download `foo-1.0.gem` files from a RubyGems server for each different ruby version installed on a user's machine. It also meant that people installing into a per-app path would need to re-download every gem for that bundle an additional time. This adds up, and makes `bundle install` slower than it needs to be. ### Was was your diagnosis of the problem? My diagnosis was that Bundler could keep a (per-source) cache of these `.gem` files, and pull from that cache instead of hitting the network whenever possible. ### What is your fix for the problem, implemented in this PR? My fix implements said cache, in a very similar way to the compact index cache (same cache slug per remote strategy, etc). This largely comes from #3983. ### Why did you choose this fix out of the possible options? I chose this fix because it is safe when used from multi-source gemfiles, it is easy to clear (`rm -rf bundle cache`), and it minimally interferes with the existing installation process.
Collaborator
|
☀️ Test successful - status-travis |
This was referenced Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that bundler would need to download
foo-1.0.gemfiles from a RubyGems server for each different ruby version installed on a user's machine. It also meant that people installing into a per-app path would need to re-download every gem for that bundle an additional time. This adds up, and makesbundle installslower than it needs to be.Was was your diagnosis of the problem?
My diagnosis was that Bundler could keep a (per-source) cache of these
.gemfiles, and pull from that cache instead of hitting the network whenever possible.What is your fix for the problem, implemented in this PR?
My fix implements said cache, in a very similar way to the compact index cache (same cache slug per remote strategy, etc). This largely comes from #3983.
Why did you choose this fix out of the possible options?
I chose this fix because it is safe when used from multi-source gemfiles, it is easy to clear (
rm -rf bundle cache), and it minimally interferes with the existing installation process.