Merged
Conversation
Because they don't play nice with ruby-core's gitignore and cause issues with ruby-core integration. Also, because it's consistent with other templates such as `gitignore.tt`.
Member
|
👍 It's better changes for human too. |
hsbt
approved these changes
Jun 16, 2020
simi
approved these changes
Jun 16, 2020
simi
left a comment
simi
left a comment
There was a problem hiding this comment.
Yes, those directories act as hidden for no reason in source code.
🤖 👍 + 🧑🤝🧑 👍 = 💯 👍
Contributor
Author
|
Thanks both! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Because they don't play nice with ruby-core's gitignore and cause issues with ruby-core integration. See ruby/ruby#3230.
Also, because it's consistent with other templates such as
gitignore.tt.This PR should fix CI for bundler at #3725.
Tasks:
I will abide by the code of conduct.