Enforce ruby-core integration workflow#3725
Merged
deivid-rodriguez merged 7 commits intomasterfrom Jun 17, 2020
Merged
Conversation
4 tasks
deivid-rodriguez
force-pushed
the
enforce_ruby_core_integration
branch
from
da11d7d to
b9895d0
Compare
4 tasks
For consistency with the other workflows.
Since it matches the files pressent in that setup.
So that newly added files and deleted files play nice with our quality specs making use of `git ls-files`.
deivid-rodriguez
force-pushed
the
enforce_ruby_core_integration
branch
from
b9895d0 to
c5aaa9c
Compare
Contributor
Author
|
This is green now! 🎉 I'd expect this to save us some trouble with future bundler & rubygems imports into ruby-core. |
hsbt
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Keeping in sync with ruby-core is tough 😅, because we not only need to backport stuff periodically, but also to forward-port the stuff that the core team changes directly in their vendored code to keep their CI green.
This PR tries to minimize the number of changes the ruby-core does directly inside our code, by running the specs the way they run them and ensuring they are green.
A problem that was mentioned in 2de34ac when this was introduced was that sometimes ruby will fail to compile. To fix that issue, I build the latest reference provided by https://github.com/ruby/setup-ruby, which should always build fine.
Build should fail now, but should pass after ruby/ruby#3230 and ruby/ruby#3213 are merged.
Tasks:
I will abide by the code of conduct.