Ship default .rubocop.yml

[utkarsh2102]

Description:

Currently, there is no .rubocop.yml shipped by default.
So when a user runs rubocop after creating a new gem via bundle gem foo, it throws a bunch of offenses.

With the default .rubocop.yml present, the number of those offenses significantly reduce by 25.

What was the end-user or developer problem that led to this PR?

A bunch of offenses thrown by rubocop since there's no default .rubocop.yml file.

What is your fix for the problem, implemented in this PR?

This PR adds a default .rubocop.yml file.

---

Tasks:

• Describe the problem / feature
• Write tests
• Write code to solve the problem
• Get code review from coworkers / friends

I will abide by the code of conduct.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[bronzdoc]

Thanks for the PR @utkarsh2102!

What other cops are need to reduce it to 0?

[utkarsh2102]

Hi @bronzdoc,

What other cops are need to reduce it to 0?

The other things that can bring down the offenses are mostly add frozen string literal comment, using double-quotes in some places, freezing a constant, and some other small things.
I can create another PR if you'd like to get them fixed, too? 😄

[utkarsh2102]

Hi @deivid-rodriguez,
I see your #3728 to remove hidden files, d'you want me to do the same here?
I suppose so? 🙈

[deivid-rodriguez]

Yes, please!

[deivid-rodriguez]

This is great, I always wanted to do this but never got to it!

[bronzdoc]

@utkarsh2102 I think if we are adding a default its better if we add all the cops that will reduce the offenses to 0 in this PR.

[deivid-rodriguez]

Looks good to me! I believe we can iterate later to remove all offenses. But if @bronzdoc wants to do that here and you're ok with doing it, go ahead! 👍

[utkarsh2102]

Thanks!
@bronzdoc, I can create another PR (soon!) to address those issues as well 😄

[deivid-rodriguez]

Thanks @utkarsh2102!!