Add changelog to metadata validation#1885
Merged
Merged
Conversation
Contributor
|
Looks good! @homu r+ |
Contributor
|
📌 Commit aea8178 has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 3, 2017
Add changelog to metadata validation Ref: #1834 rubygems/rubygems.org#1553 # Description: We need to validate changelog link during `gem build`. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1834
rubygems/rubygems.org#1553
Description:
We need to validate changelog link during
gem build.Tasks:
I will abide by the code of conduct.