Validate metadata link keys#1834
Merged
Merged
Conversation
drbrain
reviewed
Feb 6, 2017
| # "bugs" => "https://example.com/user/bestgemever/issues" | ||
| # } | ||
| # | ||
| # These links will be used on your gem's page on rubygems.org amd must pass |
segiddins
reviewed
Feb 6, 2017
| # These links will be used on your gem's page on rubygems.org amd must pass | ||
| # validation against following regex. | ||
| # | ||
| # %r{\Ahttps?:\/\/([^\s:@]+:[^\s:@]*@)?[A-Za-z\d\-]+(\.[A-Za-z\d\-]+)+\.?(:\d{1,5})?([\/?]\S*)?\z} |
Contributor
There was a problem hiding this comment.
Should we actually validate this in RubyGems are well as on .org ?
sonalkr132
force-pushed
the
metadata_links
branch
from
40716b1 to
1185830
Compare
Contributor
Author
Yes. I think we should validate both on client and the server. Doing it on client would provide immediate feedback and server side validation is for just in case (dealing with invalid links is painful). I think there is a flag which ignores the validation checks during |
Contributor
|
Then let's validate the links instead of just documenting the valid format -- that way |
sonalkr132
force-pushed
the
metadata_links
branch
from
1185830 to
475faf6
Compare
sonalkr132
changed the title
segiddins
reviewed
Mar 6, 2017
| if link_keys.include? key | ||
| if value !~ url_validation_regex | ||
| raise Gem::InvalidSpecificationException, | ||
| "metadata['#{key}'] has invalid link: #{value}" |
Contributor
|
👍 other than the one small comment (I hadn't realized you'd addressed my comment) |
sonalkr132
force-pushed
the
metadata_links
branch
from
475faf6 to
48dfc19
Compare
These keys will be validated on server and gem push will fail for invalid links.
sonalkr132
force-pushed
the
metadata_links
branch
from
48dfc19 to
4b7a695
Compare
Contributor
Author
|
Updated 💬 |
Contributor
|
👌🏻 |
|
@homu r+ |
Contributor
|
📌 Commit 4b7a695 has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 8, 2017
Validate metadata link keys # Description: We intend to deprecate form used to edit linkset of gems. Metadata will be the only way to specify homepage, codebase, documentation, wiki, mailing list and issue tracker urls. Related: rubygems/rubygems.org#1234 rubygems/rubygems.org#1557 # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
sonalkr132
added a commit
to sonalkr132/rubygems
that referenced
this pull request
Apr 3, 2017
4 tasks
homu
added a commit
that referenced
this pull request
Apr 3, 2017
Add changelog to metadata validation Ref: #1834 rubygems/rubygems.org#1553 # Description: We need to validate changelog link during `gem build`. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We intend to deprecate form used to edit linkset of gems. Metadata will be the only way to specify homepage, codebase, documentation, wiki, mailing list and issue tracker urls.
Related: rubygems/rubygems.org#1234
rubygems/rubygems.org#1557
Tasks:
I will abide by the code of conduct.