Skip to content

Add changelog to metadata validation #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
homu merged 1 commit into from
Apr 3, 2017
+9 −8
Merged

Add changelog to metadata validation #1885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions lib/rubygems/specification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,15 +456,16 @@ def files
# * All strings must be UTF-8, no binary data is allowed
#
# You can use metadata to specify links to your gem's homepage, codebase,
# documentation, wiki, mailing list and issue tracker.
# documentation, wiki, mailing list, issue tracker and changelog.
#
# s.metadata = {
# "home" => "https://bestgemever.example.io",
# "code" => "https://example.com/user/bestgemever",
# "docs" => "https://www.example.info/gems/bestgemever/0.0.1",
# "wiki" => "https://example.com/user/bestgemever/wiki",
# "mail" => "https://groups.example.com/bestgemever",
# "bugs" => "https://example.com/user/bestgemever/issues"
# "home" => "https://bestgemever.example.io",
# "code" => "https://example.com/user/bestgemever",
# "docs" => "https://www.example.info/gems/bestgemever/0.0.1",
# "wiki" => "https://example.com/user/bestgemever/wiki",
# "mail" => "https://groups.example.com/bestgemever",
# "bugs" => "https://example.com/user/bestgemever/issues",
# "changelog" => "https://example.com/user/bestgemever/CHANGELOG.md"
# }
#
# These links will be used on your gem's page on rubygems.org and must pass
Expand Down Expand Up @@ -2845,7 +2846,7 @@ def validate packaging = true

def validate_metadata
url_validation_regex = %r{\Ahttps?:\/\/([^\s:@]+:[^\s:@]*@)?[A-Za-z\d\-]+(\.[A-Za-z\d\-]+)+\.?(:\d{1,5})?([\/?]\S*)?\z}
link_keys = ["home", "code", "docs", "wiki", "mail", "bugs"]
link_keys = ["home", "code", "docs", "wiki", "mail", "bugs", "changelog"]

metadata.each do|key, value|
if !key.kind_of?(String)
Expand Down