[Version] Make hash based upon canonical segments#1659
Merged
Conversation
Contributor
Author
|
Failing because the bundler submodule needs to be updated to include a fix that accounts for the release of rack 2 |
segiddins
force-pushed
the
seg-canonical-segments
branch
from
4492166 to
15ca22f
Compare
|
@homu r+ |
Contributor
|
📌 Commit 15ca22f has been approved by |
homu
added a commit
that referenced
this pull request
Jul 19, 2016
[Version] Make hash based upon canonical segments # Description: Closes #1617. This makes sure the hash reflects a `canonical_segments` property, which just removes trailing 0s from the numeric and pre-release segments as `<=>` does # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends - [ ] [Squash commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Contributor
Contributor
|
☀️ Test successful - status |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #1617.
This makes sure the hash reflects a
canonical_segmentsproperty, which just removes trailing 0s from the numeric and pre-release segments as<=>doesTasks:
I will abide by the code of conduct.