Remove canonical_segments check#16509
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jan 21, 2024
Merged
Conversation
Member
|
This script is used on arbitrary Rubies in the PATH etc to check if it is Ruby 3.1 or later. Though if it still errors out with a non-zero exit code and prints nothing to stdout (stderr is fine since we do |
Member
Author
|
Yeah, tbc I mean that primarily as a contrast. Even macos system ruby ships with rubygems 3.0.3, released in 2019. But reasonable enough if folks want to maintain support for the oldest rubies. |
MikeMcQuaid
approved these changes
Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Ruby 3.1 ships with rubygems 3.3.3, which was released 2021-12-24.
Gem::Version#canonical_segmentswas introduced in 2016.