Conversation
orien
approved these changes
Nov 2, 2018
Member
orien
left a comment
There was a problem hiding this comment.
Thanks @johnsyweb 😄
It's interesting that the build didn't pick that up. It runs against Ruby 2.3.
Ah, I see the Ruby 2.3 Docker image we use has the latest Rubygems installed.
https://github.com/docker-library/ruby/blob/9e6a656108d5227e5788dcf5f0e4c63e726dc3e6/2.3/stretch/Dockerfile#L13
Contributor
Author
|
Ah yes. Perhaps we should just fail loudly on old ruby gems. |
Merged
Contributor
Author
|
I think #46 is a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/envato/solid_octane_service/pull/190 and https://github.com/envato/solid_octane_service/pull/191 failed to annotate because solid_octane_service is on Ruby 2.3.5, which doesn't include ruby/rubygems#1659 . https://github.com/envato/solid_octane_service/pull/192 worked with this patch, which isn't perfect but I think is a reasonable fallback for old rubies.
Change
Gem::Versions#segmentswhereGem::Versions#canonical_segmentsisn't available.gem buildwarnings... #40 )