Skip to content

switch to not deprecated API#174

Merged
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/only-load-required-entry-points
Jan 22, 2020
Merged

switch to not deprecated API#174
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/only-load-required-entry-points

Conversation

@dirk-thomas
Copy link
Member

Related to ros2/ros2cli#436.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels Jan 18, 2020
@dirk-thomas dirk-thomas self-assigned this Jan 18, 2020
@dirk-thomas dirk-thomas merged commit b9e6ac5 into master Jan 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/only-load-required-entry-points branch January 22, 2020 16:38
@dirk-thomas
Copy link
Member Author

Technically this one will need a minimum version dependency on the next version of ros2cli.

@mikaelarguedas
Copy link
Member

This appears to have broken all the end-to-end tests https://ci.ros2.org/view/nightly/job/nightly_linux_release/1422/testReport/junit/sros2.test.sros2.commands.security.verbs/

@mjcarroll
Copy link
Member

It has, and @dirk-thomas is looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants