only load required entry points which improves the performance#436
Merged
dirk-thomas merged 4 commits intomasterfrom Jan 22, 2020
Merged
only load required entry points which improves the performance#436dirk-thomas merged 4 commits intomasterfrom
dirk-thomas merged 4 commits intomasterfrom
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
added
enhancement
mjcarroll
approved these changes
Jan 18, 2020
Member
|
Sorry, I was only approving the first commit, didn't realize that it marks the whole thing as approved, still looking. |
mjcarroll
reviewed
Jan 18, 2020
mjcarroll
approved these changes
Jan 18, 2020
Member
mjcarroll
left a comment
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with green CI and a small nit about documentation.
This was referenced Jan 18, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/only-load-required-entry-points
branch
from
aef5a5c to
7cc848f
Compare
mjcarroll
approved these changes
Jan 18, 2020
Member
|
Cancelled hanging windows CI, here new one:
|
Member
Author
|
While the Windows build has a very high test failure count (75) that seems to match the latest nightly Windows Debug build: https://ci.ros2.org/view/nightly/job/nightly_win_deb/1504/ Merging... |
delete-merged-branch
bot
deleted the
dirk-thomas/only-load-required-entry-points
branch
This was referenced Jan 23, 2020
Merged
Member
|
I noticed that autocomplete isn't working at all in master in all the ros2 cli tools. @dirk-thomas can you take a look? If not, I can try to fix it (though I don't have much context). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #424.
The changes are split over four commits to ease the review.