Skip to content

Fix 137: removes hardcoded sros2testCA #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcarroll merged 1 commit into from
Jun 27, 2019
Merged

Fix 137: removes hardcoded sros2testCA #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sros2/test/sros2/commands/security/verbs/test_create_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

from ros2cli import cli

from sros2.api import _DEFAULT_COMMON_NAME
from sros2.api import create_keystore
from sros2.policy import get_transport_schema

Expand Down Expand Up @@ -102,7 +103,7 @@ def test_create_key(node_keys_dir):
def test_cert_pem(node_keys_dir):
cert = load_cert(os.path.join(node_keys_dir, 'cert.pem'))
check_common_name(cert.subject, u'/test_node')
check_common_name(cert.issuer, u'sros2testCA')
check_common_name(cert.issuer, _DEFAULT_COMMON_NAME)

# Verify that the hash algorithm is as expected
assert isinstance(cert.signature_hash_algorithm, hashes.SHA256)
Expand Down Expand Up @@ -138,8 +139,8 @@ def test_governance_p7s(node_keys_dir):

def test_identity_ca_cert_pem(node_keys_dir):
cert = load_cert(os.path.join(node_keys_dir, 'identity_ca.cert.pem'))
check_common_name(cert.subject, u'sros2testCA')
check_common_name(cert.issuer, u'sros2testCA')
check_common_name(cert.subject, _DEFAULT_COMMON_NAME)
check_common_name(cert.issuer, _DEFAULT_COMMON_NAME)


def test_key_pem(node_keys_dir):
Expand Down Expand Up @@ -171,8 +172,8 @@ def test_permissions_xml(node_keys_dir):

def test_permissions_ca_cert_pem(node_keys_dir):
cert = load_cert(os.path.join(node_keys_dir, 'permissions_ca.cert.pem'))
check_common_name(cert.subject, u'sros2testCA')
check_common_name(cert.issuer, u'sros2testCA')
check_common_name(cert.subject, _DEFAULT_COMMON_NAME)
check_common_name(cert.issuer, _DEFAULT_COMMON_NAME)

signatory = load_cert(os.path.join(node_keys_dir, 'identity_ca.cert.pem'))
assert verify_signature(cert, signatory)