Backport kilted/use chrono durations in update methods#1563
Backport kilted/use chrono durations in update methods#1563riv-mjohnson wants to merge 2 commits intoros2:kiltedfrom
Conversation
…no::duration, std::chrono::duration) replacements. (ros2#1533) Signed-off-by: Mark Johnson <104826595+riv-mjohnson@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
In general we use mergify to backport PRs, but we can't backported this one because it's breaking ABI
|
Is it still an ABI breaking change if the old methods aren't deprecated? |
In this case, adding the |
|
Does that mean it won't be possible to patch this bug in a non-breaking way on humble/jazzy/kilted? Is the best we can do just to update the comments to reflect that the times are in nanoseconds? I was hoping to get these changes into rviz so I could nicely fix the update rates in MoveIt (where, since the increments are 1e9 times too large, it tries to update the entire robot state on every tick, causing the entire UI to lag out). |
3 participants
Description
Backports #1533 to kilted, removing deprecation warnings.
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information