[Foxy backport]: De-deplicate type_support_map.h header#83
Merged
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/deduplicate_foxy
branch
from
82b3647 to
43cb097
Compare
clalancette
changed the title
Contributor
|
@j-rivero FYI, I retargeted this to the |
added 2 commits
October 19, 2020 16:26
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/deduplicate_foxy
branch
from
9497aff to
0ecfe2e
Compare
Author
|
Merged with foxy branch and fixed the warning in the benchmark test. |
clalancette
reviewed
Nov 6, 2020
Comment on lines
+21
to
+22
| #warning rosidl_typesupport_cpp/type_support_map.h header is deprecated \ | ||
| in favor of rosidl_typesupport_c/type_support_map.h. |
Contributor
There was a problem hiding this comment.
Hm, I wonder if we should remove this warning for the Foxy backport. After all, downstream consumers may already be relying on it. @jacobperron thoughts?
Member
There was a problem hiding this comment.
I agree, we should avoid backporting deprecation warnings.
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/deduplicate_foxy
branch
from
3603dc2 to
794827f
Compare
Author
Makes sense, 3603dc2
|
jacobperron
approved these changes
Nov 6, 2020
clalancette
approved these changes
Nov 6, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good with green CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #81 to Foxy branch.
Testing in foxy CI: