rosbag2_py pybind wrapper for "record" - remove rosbag2_transport_py#702
rosbag2_py pybind wrapper for "record" - remove rosbag2_transport_py#702emersonknapp merged 8 commits intomasterfrom
Conversation
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
requested review from
jaisontj and
prajakta-gokhale
and removed request for
a team
Karsten1987
left a comment
Karsten1987
left a comment
There was a problem hiding this comment.
sweet!
LGTM with green CI.
|
Gist: https://gist.githubusercontent.com/emersonknapp/e82c17523b5d1535935dc776b2246fc9/raw/dc1536d0818be644c16e0d3e7341e1f4c8107608/ros2.repos
|
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
|
Windows cmake warning is unrelated - it's from the rti cmake module |
|
it looks like that change introduced a regression on the tests. We see the same test failures on all platforms: |
|
That's no good - I am looking into it |
|
according to @sloretz we might want to get rid of pycapsules completely: see https://github.com/ros2/rclpy/pull/741/files |
|
Oh - we must have had a race condition in that I ran my CI before that got pushed. Thanks for the context. I am thinking that I would prefer to patch fix this instead of revert, right now. |
Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Fix rosbag2_py transport test for py capsule Change introduced by ros2/rclpy#741 conflicted with parallel work in #702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Fix rosbag2_py transport test for py capsule Change introduced by ros2/rclpy#741 conflicted with parallel work in ros2#702, the combination causing nightly test failure for `rosbag2_py`'s `_transport.cpp` tests. Fix to use the new `py::object` for `rmw_qos_profile_t` to fix the tests. Signed-off-by: Emerson Knapp <eknapp@amazon.com>
2 participants
Depends on #693
Followup to
rosbag2_py::PlayerAdd a
rosbag2_py::Recorder- and exposeRecordOptionsto Python. Removerosbag2_transport_python.cpp- it is fully replaced.