Introducing Reindexer CLI

[jhdcs]

Fixes #395
Followup to #641

This PR adds the ros2bag/rosbag2_py CLI so that end users can reindex their bag files.

[emersonknapp]

LGTM once green CI

Small comment - did you intent to re-replace the multiple_files test, or do you want to revert that back to the fixed master version?

[jhdcs]

Oh crud! No, I didn't intend to re-upload the broken test... Also, I might have had something funny go on with the rebasing I did. Looks like you found a place that might have occurred? I'll get your "nitpicks" fixed! (I quoted Nitpicks, because I don't think they're very nit-picky)

[emersonknapp]

Sorry - this'll need a quick rebase and conflict resolution - we've been touching some of the same files. It should be a simple resolution, though, we both added a python module to rosbag2_py

[jhdcs]

It looks like the rebase was successful on my end, so hopefully this works for you too?

[emersonknapp]

Ah - I'm realizing why those database files are re-added, and it's that we moved them to rosbag2_tests in the previous step, so that we could be sure to have access to rosbag2_storage_default_plugins in rosbag2_cpp. As this stands, we do have access to those plugins from rosbag2_py as a <test_depend>, so i'll just kick off CI now

[jhdcs]

Wait, I'm confused. Should I remove the database files? I thought I had stopped re-introducing them. Unless you meant the ones in rosbag2_py, which I'm just using as a test. If there's a way to just use one set of database files across all packages that would be nice... Or did I already do that before?

I think I'm making myself confused...

[emersonknapp]

Gist: https://gist.githubusercontent.com/emersonknapp/a0f471c5073bd874049e9c10ddb2bfe9/raw/5eae459c861e4b2e910b1530f57b3ca917adc8c2/ros2.repos
BUILD args: --packages-up-to rosbag2_py ros2bag rosbag2_tests
TEST args: --packages-select rosbag2_py ros2bag rosbag2_tests
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8072

• Linux
• Linux-aarch64
• macOS
• Windows

[emersonknapp]

These multiple_files db3 files look like a duplicate of the ones that you originally introduced to rosbag2_cpp for the Reindexer class test. We then moved them to rosbag2_tests. I'm worried if they're exact copies of the originals, then they will also have a problem on OSX - we'll see when the above CI goes through. I'm ok with a little bit of the duplication right now - the alternatives i see are moving this reindexer test to rosbag2_tests, or moving the test bag assets to rosbag2_test_common as a common resource for packages to use. I don't feel too particular about fixing that now though.

Note: there's a failing test problem right now that those will show for rosbag2_py's Transport tests - see the conversation at #702. We'll need to make sure it's green before merging this, but I'll help push it through.

[jhdcs]

I thought I had copied over the ones you added. If there's a problem with the OSX test, then I'll delete them, and re-copy your database files again.

[jhdcs]

Looks like that might have been the old database! All right, swapping it out...

[emersonknapp]

Note: just waiting on #705 before moving this forward. I'll do a rebase and test asap (probably tomorrow morning after the WG meeting) then merge if it's green

[emersonknapp]

Gist: https://gist.githubusercontent.com/emersonknapp/a848456e0c1996c86fb34abc646482bc/raw/5eae459c861e4b2e910b1530f57b3ca917adc8c2/ros2.repos
BUILD args: --packages-up-to rosbag2_py ros2bag rosbag2_tests rosbag2
TEST args: --packages-select rosbag2_py ros2bag rosbag2_tests rosbag2
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/8087

• Linux
• Linux-aarch64
• macOS
• Windows

[emersonknapp]

Windows warnings are the following two:

• Windows warning in nightly rclpy#752
• CMake Windows warning CMP0115 eclipse-cyclonedds/cyclonedds#741