Skip to content

Use Python 3.8 on OSX for Foxy#663

Merged
sloretz merged 3 commits intomasterfrom
sloretz/foxy_osx/python38
May 11, 2020
Merged

Use Python 3.8 on OSX for Foxy#663
sloretz merged 3 commits intomasterfrom
sloretz/foxy_osx/python38

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented May 7, 2020

Replaces #641, which has more context.

@sloretz sloretz self-assigned this May 7, 2020
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-663 May 7, 2020 19:22 Inactive
@sloretz sloretz mentioned this pull request May 7, 2020
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also update the building from source instructions too: https://index.ros.org/doc/ros2/Installation/Foxy/macOS-Development-Setup/

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author

sloretz commented May 11, 2020

We should probably also update the building from source instructions too

Added in 1762143

@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-663 May 11, 2020 20:42 Inactive
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author

sloretz commented May 11, 2020

I think we can remove python3 from this line.

deleted python3 from that line in 820b205

@sloretz sloretz merged commit e9f97d8 into master May 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the sloretz/foxy_osx/python38 branch May 11, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants