7.0.0#1583
Conversation
|
Comparison: 6.3.1...master |
|
Should this be a major bump? I don't know if the changes to either the declare parameters functions or the changes to the |
I think that a major bump is reasonable considering that previous code can break, e.g.: node->declare_parameter("asd", 3);
node->set_parameter({"asd", "string"});that was previously valid, now it isn't. |
|
I think we should fast-forward this change to avoid a merge commit. I don't know if we've done that via GitHub in the past or manually. |
Yeah, I called that out in the initial description. I don't think the web UI gives you any buttons to do that. I've been doing it manually for other repos, and pushing the tag along with it at the same time. Seems to work pretty well. |
This change should be fast-forward merged after approval.