Skip to content

7.0.0#1583

Merged
cottsay merged 1 commit into
masterfrom
release/6.4.0
Mar 18, 2021
Merged

7.0.0#1583
cottsay merged 1 commit into
masterfrom
release/6.4.0

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Mar 18, 2021

This change should be fast-forward merged after approval.

@cottsay cottsay self-assigned this Mar 18, 2021
Comment thread rclcpp/CHANGELOG.rst Outdated
Comment thread rclcpp/CHANGELOG.rst Outdated
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 18, 2021

Comparison: 6.3.1...master

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 18, 2021

Should this be a major bump? I don't know if the changes to either the declare parameters functions or the changes to the struct usage in the public API constitute an update to the major version according to semver @ivanpauno @mabelzhang

@ivanpauno
Copy link
Copy Markdown
Member

I don't know if the changes to either the declare parameter

I think that a major bump is reasonable considering that previous code can break, e.g.:

node->declare_parameter("asd", 3);
node->set_parameter({"asd", "string"});

that was previously valid, now it isn't.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay changed the title 6.4.0 7.0.0 Mar 18, 2021
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 18, 2021

I think we should fast-forward this change to avoid a merge commit. I don't know if we've done that via GitHub in the past or manually.

@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented Mar 18, 2021

I think we should fast-forward this change to avoid a merge commit. I don't know if we've done that via GitHub in the past or manually.

Yeah, I called that out in the initial description. I don't think the web UI gives you any buttons to do that. I've been doing it manually for other repos, and pushing the tag along with it at the same time. Seems to work pretty well.

@cottsay cottsay merged commit 7bfda87 into master Mar 18, 2021
@delete-merged-branch delete-merged-branch Bot deleted the release/6.4.0 branch March 18, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants