Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype of ros2/design#300.
Depends on #1410.
Diff omitting #1410: https://github.com/ros2/rclcpp/pull/1408/files/ec90cb53091e355dcf194c944fcaf239c5fa6699..9197a8f2bfe9da6e54f3e30779b3b1c0236339f2.
Not quite ready yet.
Things to solve before merging:
Get the final topic name before creating a publisher/subscription
rclcppmethod forNode(PR).create_subscriptionandcreate_publishercan be called without a parameters interfaceI'm not quite sure what to do about this.
If the user wants to only provide a topics interface (without using qos overrides), that should be ok.
Maybe fail when qos overrides are enabled and a parameters interface isn't provided?
rclcppcode increate_publisher.hpp/create_subscription.hppcomments.Added notes, this can be resolved in a follow-up.
Improve QosOverridingOptions API
Not a blocker for merging this, but we should have minimal API that won't be deprecated.
Maybe QosOverridingOptions could use the builder pattern or the parameter idiom to make things easier.
I definitely also want either builder pattern/parameters idiom in
PublisherOptions/SubscriptionOptions, but that can be done in a follow up.Test coverage
Move things that can be shared between rclcpp/rclpy to rcl/rmw
rclcpp::QosPolicyKindvalues based on that. Conversions to/from strings can be implemented there (PR).Support in other client libraries
rclpy(PR)