Skip to content

Add functions to convert between qos policy values and strings#284

Merged
ivanpauno merged 5 commits intomasterfrom
ivanpauno/qos-string-conversions
Oct 19, 2020
Merged

Add functions to convert between qos policy values and strings#284
ivanpauno merged 5 commits intomasterfrom
ivanpauno/qos-string-conversions

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Required by ros2/rclcpp#1408, the idea is to avoid custom conversions in different clients (rclcpp, rclpy).

Replaces ros2/rcl#836.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Oct 19, 2020
@ivanpauno ivanpauno requested a review from jacobperron October 19, 2020 13:56
@ivanpauno ivanpauno self-assigned this Oct 19, 2020
@ivanpauno ivanpauno mentioned this pull request Oct 19, 2020
10 tasks
ivanpauno and others added 4 commits October 19, 2020 13:45
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested a review from jacobperron October 19, 2020 16:53
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno
Copy link
Copy Markdown
Member Author

CI (testing only rmw):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 6f01b55 into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/qos-string-conversions branch October 19, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants