Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

Fix dependency with catkin 0.7.2#155

Merged
wjwwood merged 1 commit into
ros:kinetic-develfrom
jspricke:catkin_fix
Sep 22, 2016
Merged

Fix dependency with catkin 0.7.2#155
wjwwood merged 1 commit into
ros:kinetic-develfrom
jspricke:catkin_fix

Conversation

@jspricke
Copy link
Copy Markdown
Member

since ros/catkin#813 catkin checks that the
dependency was actually found.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Sep 21, 2016

It's still not passing.

@dirk-thomas any input on what to change here? I remember some issue comment traffic about things found with pkgconfig. Should we just remove it from the list and pass the include dirs and libraries separately?

@jspricke
Copy link
Copy Markdown
Member Author

I guess libpcre3-dev is missing in the build depends, at least it's not in the jankins logs.

@dirk-thomas
Copy link
Copy Markdown
Member

Part of the referenced change has been reverted in ros/catkin#825. But the CMake warning indicates that for either of the two exported DEPENDS pcrecpp / libpcrecpp there are no CMake variables defined for include directories and libraries (which makes the export a no-op). I don't know what variables you expect to be defined but currently the DEPENDS (with as well as without this patch) doesn't do what you expect it to do.

@dirk-thomas
Copy link
Copy Markdown
Member

If this dependency you might want to find it with REQUIRED to ensure the configure steps fails if the module was not found. And then it could be that a necessary build dependency is not correctly declared as @jspricke pointed out.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Sep 21, 2016

@jspricke will you allow me to push to your pr branch? See: https://github.com/blog/2247-improving-collaboration-with-forks

@jspricke
Copy link
Copy Markdown
Member Author

@wjwwood I found an easier fix, what do you think?

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Sep 22, 2016

Yeah, even better. Looks like it was missed when removing pcre stuff from in this pr: #113

@k-okada fyi

@wjwwood wjwwood merged commit cfa9ab9 into ros:kinetic-devel Sep 22, 2016
@jspricke jspricke deleted the catkin_fix branch September 23, 2016 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants