This repository was archived by the owner on Aug 3, 2020. It is now read-only.
[urdf] address gcc6 build error and tune#157
Merged
Merged
Conversation
14 tasks
Member
|
It looks like the pr failure is from an existing issue on xenial? Probably a ripple from the latest catkin release. |
Member
|
This will need to be rebased after we fix that in: #155 |
With gcc6, compiling fails with `stdlib.h: No such file or directory`, as including '-isystem /usr/include' breaks with gcc6, cf., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129. This commit addresses this issue for this package in the same way it was addressed in various other ROS packages. A list of related commits and pull requests is at: ros/rosdistro#12783 Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
020fb61 to
819c10f
Compare
Contributor
Author
|
This patch has been rebased after #155. |
Contributor
Author
|
Please merge if there are not any further concerns. Thanks. |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With gcc6, compiling fails with
stdlib.h: No such file or directory, as including '-isystem /usr/include' breaks with gcc6, cf., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.This commit addresses this issue for this package in the same way it was addressed in various other ROS packages. A list of related commits and pull requests is at ros/rosdistro#12783.