Closed
Conversation
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Contributor
|
Obsoleted by #212, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not get pluginlib to compile with a homebrew llvm clang. Note this is different of AppleClang which is shipped by default on OSX. The filesystem libraries are marked explicitly unavailable until OSX 10.15.
That's the same problem as described here: https://answers.ros.org/question/338832/ros2-source-install-macos-10151-qt_gui_cpp-fails/
Don't have much more info about this though. Some information might be here:
https://stackoverflow.com/questions/42633477/macos-clang-c17-filesystem-header-not-found
Might be related to #168
As a general question, I am wondering though why we ship pluginlib with this custom logic. It anyways depends on
rcpputilsalready, why not using their filesystem implementation?