Remove signals from find_package(Boost COMPONENTS ...).
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf2 is using signals2, which is not the same library. Additionally, signals2 has always been header only, and header only libraries must not be listed in find_package. Boost 1.69 removed the old signals library entirely, so the otherwise useless `COMPONENTS signals` actually breaks the build.
|
Are there any plans to provide a hotfix of this issue with the 0.6.5 release? I'm currently trying to build ROS melodic of Fedora 30 and was running into this issue. By default the ROS installation setup/configuration phase grabs the 0.6.5 release and still has signals in the CMakeLists.txt file. Fedora 30 and above contains boost versions that no longer contain the original Signals library (1.69+) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf2 is using signals2, which is not the same library. Additionally, signals2 has always been header only, and header only libraries must not be listed in
find_package(Boost COMPONENTS ...).Boost 1.69 removed the old signals library entirely, so the otherwise harmless
COMPONENTS signalsactually breaks the build now.