Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cob_light] removed unused Boost signals dependency #406

Merged
merged 1 commit into from
Dec 12, 2019
Merged

[cob_light] removed unused Boost signals dependency #406

merged 1 commit into from
Dec 12, 2019

Conversation

lopsided98
Copy link
Contributor

cob_light depends on Boost signals2, which is a header only library that does not need to be found using find_package. The CMakeLists.txt tries to find Boost signals (v1). This library was removed in Boost 1.69, causing this package to fail to build.

@lopsided98 lopsided98 changed the title cob_light: removed unused Boost signals dependency [cob_light] removed unused Boost signals dependency Dec 10, 2019
@fmessmer
Copy link
Contributor

sounds reasonable

just for my understanding:
in what architecture/distro/setup do you get build errors?
can you post a log?

@lopsided98
Copy link
Contributor Author

I am using Nix, but this problem will occur on any distribution with Boost >=1.69. This is the error message:

CMake Error at /nix/store/0rwxndjblrj8ashnfv0g9sxcnv2mdiw3-cmake-3.15.4/share/cmake-3.15/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Boost (missing: signals) (found version "1.69.0")
Call Stack (most recent call first):
  /nix/store/0rwxndjblrj8ashnfv0g9sxcnv2mdiw3-cmake-3.15.4/share/cmake-3.15/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/0rwxndjblrj8ashnfv0g9sxcnv2mdiw3-cmake-3.15.4/share/cmake-3.15/Modules/FindBoost.cmake:2161 (find_package_handle_standard_args)
  CMakeLists.txt:8 (find_package)


-- Configuring incomplete, errors occurred!

Many ROS packages have this same problem: ros-planning/navigation#945, ros/geometry2#354, ros/geometry#180, moveit/moveit#1353, ros/ros_comm#1580, PR2/pr2_common_actions#39, ros-perception/calibration#43

Copy link
Contributor

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the patch and the explanation....I took care of other cob_* repos with the same problem....

@fmessmer fmessmer merged commit 2f01359 into 4am-robotics:kinetic_dev Dec 12, 2019
@lopsided98 lopsided98 deleted the cob-light-boost-signals branch December 12, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants