Switch to using the filesystem implementation in rcpputils.#239
Merged
clalancette merged 1 commit intofoxy-develfrom Nov 2, 2020
Merged
Conversation
That implementation is more complete and better tested. This also gets us closer to remove the pluginlib implementation of the filesystem helper. Note that this doesn't really change the dependencies of this package; this package already recursively depended on rcpputils, now it just directly depends on it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
I'm going to run CI on this, but as far as I can tell there are no tests that exercise this piece of code. So CI will only tell us if it builds.
|
Contributor
Author
|
I did some basic testing of rqt with this patch in place, and I didn't see any changes. With the green CI and the approval, I'm going to go ahead and merge it. Thanks for the feedback. |
clalancette
added a commit
that referenced
this pull request
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That implementation is more complete and better tested. This
also gets us closer to remove the pluginlib implementation
of the filesystem helper.
Note that this doesn't really change the dependencies of this
package; this package already recursively depended on rcpputils,
now it just directly depends on it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org