Revert "Switch to using the filesystem implementation in rcpputils. (…#246
Merged
clalancette merged 1 commit intofoxy-develfrom Jan 26, 2021
Merged
Revert "Switch to using the filesystem implementation in rcpputils. (…#246clalancette merged 1 commit intofoxy-develfrom
clalancette merged 1 commit intofoxy-develfrom
Conversation
Contributor
Author
|
The Rpr job shouldn't be running for this branch; we need to land ros/rosdistro#28132 so that this branch is now only for Foxy. |
cottsay
approved these changes
Jan 26, 2021
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
Looks like it never got released, so I think this should be OK to do.
Contributor
Author
|
Thanks, appreciated. Merging this onto foxy-devel (the code is still on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#239)"
This reverts commit 1c4ae0b.
I made a mistake when I merged #239. It should never have been merged onto the
foxy-develbranch, but onlygalactic-devel. So I made a new branch calledgalactic-develwith this commit, and now we should revert #239 off of thefoxy-develbranch. @cottsay I'd appreciate a review of this, thanks.