Move test dependencies into BUILD_TESTING to avoid build error#241
Merged
gaoethan merged 2 commits intoros-perception:ros2from Aug 16, 2018
Merged
Move test dependencies into BUILD_TESTING to avoid build error#241gaoethan merged 2 commits intoros-perception:ros2from
gaoethan merged 2 commits intoros-perception:ros2from
Conversation
mikaelarguedas
requested changes
Aug 15, 2018
Contributor
mikaelarguedas
left a comment
mikaelarguedas
left a comment
There was a problem hiding this comment.
This code is duplicated so it should be removed from this file rather than moved inside the BUILD_TESTING block.
As most linter tests are failing (see log from ros2/rosdistro#260 (comment)), we should either fix the test failures or disable the tests will not be fixed (if for example we want to keep the ROS 1 style to keep the ros2 branch as close to upstream as possible)
cv_bridge/CMakeLists.txt
Outdated
|
|
||
| if(BUILD_TESTING) | ||
| find_package(ament_lint_auto REQUIRED) | ||
| ament_lint_auto_find_test_dependencies() |
Contributor
There was a problem hiding this comment.
This code is already present in the test/CMakeLists.txt file. So having it here as well is redundant, it would be better to remove it.
Contributor
Author
|
It's removed accordingly, thanks @mikaelarguedas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue in ros2/rosdistro#260 due to some test dependencies that are find_package'd outside of a
BUILD_TESTINGconditional.