Skip to content

Fix wrong usage of rclcpp::Duration constructor #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JWhitleyWork merged 2 commits into from
Jan 26, 2021
Merged

Fix wrong usage of rclcpp::Duration constructor #627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1017423
Fix wrong usage of rclcpp::Duration constructor
ivanpauno Jan 25, 2021
71e6255
please linters
ivanpauno Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion image_view/src/video_recorder_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ void VideoRecorderNode::callback(const sensor_msgs::msg::Image::ConstSharedPtr &
codec.c_str(), size.height, size.width, fps);
}

if ((rclcpp::Time(image_msg->header.stamp) - g_last_wrote_time) < rclcpp::Duration(1.0 / fps)) {
if (
(rclcpp::Time(image_msg->header.stamp) - g_last_wrote_time) <
rclcpp::Duration::from_seconds(1.0 / fps))
{
// Skip to get video with correct fps
return;
}
Expand Down