Fix wrong usage of rclcpp::Duration constructor#627
Merged
JWhitleyWork merged 2 commits intoJan 26, 2021
Merged
Conversation
Collaborator
|
@ivanpauno Can you please rebase your branch for this fix on the |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/fix-Duration-migration-ros1-ros2
branch
from
a0ec17b to
1017423
Compare
Contributor
Author
Should be fixed now |
Collaborator
|
@ivanpauno It looks like you've introduced some formatting errors. Please see the results of the Github actions CI job. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Contributor
Author
Fixed those |
Contributor
Author
|
The remaining failures seem unrelated to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ros2/rclcpp#1432 for an explanation of the issue.