Skip to content

Set StaticLayer to non-current as soon as an update is received#5984

Merged
SteveMacenski merged 5 commits intoros-navigation:mainfrom
botsandus:static-layer-invalidation-main
Mar 2, 2026
Merged

Set StaticLayer to non-current as soon as an update is received#5984
SteveMacenski merged 5 commits intoros-navigation:mainfrom
botsandus:static-layer-invalidation-main

Conversation

@tonynajjar
Copy link
Copy Markdown
Contributor

@tonynajjar tonynajjar commented Feb 24, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • Set Static Layer to not current as soon as we receive an update
  • Match how controller and planner server wait for costmap
  • Add log for how long we waiting for costmap if the planner or controller server miss a loop

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@tonynajjar
Copy link
Copy Markdown
Contributor Author

Don't review yet

@SteveMacenski
Copy link
Copy Markdown
Member

Oh... uh... sorry

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
…rServer

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@tonynajjar tonynajjar force-pushed the static-layer-invalidation-main branch from ec78b4a to eeae89b Compare February 26, 2026 08:07
@tonynajjar tonynajjar changed the title Add external invalidation support to StaticLayer Set StaticLayer to non-current as soon as an update is received Feb 26, 2026
Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look once you do the updates we talked about :-)

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft?

@tonynajjar
Copy link
Copy Markdown
Contributor Author

tonynajjar commented Feb 27, 2026

Should be it but didn't properly test yet. Wait till next week

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@tonynajjar tonynajjar marked this pull request as ready for review March 2, 2026 12:18
@tonynajjar
Copy link
Copy Markdown
Contributor Author

@SteveMacenski ready from my side

@SteveMacenski SteveMacenski merged commit e85bbba into ros-navigation:main Mar 2, 2026
15 of 16 checks passed
@tonynajjar tonynajjar deleted the static-layer-invalidation-main branch March 10, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants