Skip to content

fix unit tests from commit 797a171's float32 precision issues. #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveMacenski merged 1 commit into from
Feb 12, 2026
Merged

fix unit tests from commit 797a171's float32 precision issues. #5957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions nav2_ros_common/test/test_validation_messages.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
// limitations under the License.

#include <gtest/gtest.h>

#include <cmath>
#include <limits>

#include "nav2_ros_common/validate_messages.hpp"

TEST(ValidateMessagesTest, DoubleValueCheck) {
Expand Down Expand Up @@ -213,7 +217,8 @@ TEST(ValidateMessagesTest, MapMetaDataCheck) {
EXPECT_FALSE(nav2::validateMsg(invalid_map_meta_data));

// Test borderline resolution message (minimum accepted)
valid_map_meta_data.resolution = 1e-6;
valid_map_meta_data.resolution = std::nextafterf(
1e-6f, std::numeric_limits<float>::infinity());
EXPECT_TRUE(nav2::validateMsg(valid_map_meta_data));

// Test invalid MapMetaData message with zero width
Expand Down Expand Up @@ -245,7 +250,8 @@ TEST(ValidateMessagesTest, OccupancyGridCheck) {
EXPECT_TRUE(nav2::validateMsg(valid_occupancy_grid));

// Test borderline resolution message
valid_occupancy_grid.info.resolution = 1e-6;
valid_occupancy_grid.info.resolution = std::nextafterf(
1e-6f, std::numeric_limits<float>::infinity());
EXPECT_TRUE(nav2::validateMsg(valid_occupancy_grid));

// Test invalid resolution message (too small)
Expand Down
Loading