fix unit tests from commit 797a171's float32 precision issues.#5957
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Feb 12, 2026
Merged
fix unit tests from commit 797a171's float32 precision issues.#5957SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
mini-1235
requested changes
Feb 12, 2026
Collaborator
mini-1235
left a comment
There was a problem hiding this comment.
Please fix linting :)
…ed it here Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
Contributor
Author
|
Linting fixed! |
SteveMacenski
approved these changes
Feb 12, 2026
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
…ed it here (ros-navigation#5957) Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
EricoMeger
pushed a commit
to EricoMeger/navigation2
that referenced
this pull request
Feb 22, 2026
…ed it here (ros-navigation#5957) Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
The unit tests added in commit 797a171 has floating point precision issues (caused by converting 1e-6 to float32). Fixed this problem by using
std::nextafterf(1e-6f, std::numeric_limits<float>::infinity());for comparison.For Maintainers:
backport-*.