Skip to content

fix unit tests from commit 797a171's float32 precision issues.#5957

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Rosayxy:mapmeta-fix
Feb 12, 2026
Merged

fix unit tests from commit 797a171's float32 precision issues.#5957
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Rosayxy:mapmeta-fix

Conversation

@Rosayxy
Copy link
Copy Markdown
Contributor

@Rosayxy Rosayxy commented Feb 12, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on Ubuntu
Robotic platform tested on Unit tests
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

The unit tests added in commit 797a171 has floating point precision issues (caused by converting 1e-6 to float32). Fixed this problem by using std::nextafterf(1e-6f, std::numeric_limits<float>::infinity()); for comparison.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Copy link
Copy Markdown
Collaborator

@mini-1235 mini-1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix linting :)

…ed it here

Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
@Rosayxy
Copy link
Copy Markdown
Contributor Author

Rosayxy commented Feb 12, 2026

Linting fixed!

@SteveMacenski SteveMacenski merged commit ee73b9e into ros-navigation:main Feb 12, 2026
16 checks passed
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
…ed it here (ros-navigation#5957)

Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
EricoMeger pushed a commit to EricoMeger/navigation2 that referenced this pull request Feb 22, 2026
…ed it here (ros-navigation#5957)

Signed-off-by: Rosayxy <rosaxinyu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants