Added IsGoalNearby BT node#5843
Conversation
c6754fc to
8e1ffac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
56dc4ee to
0e47b00
Compare
Signed-off-by: Jakubach <jakubach@gmail.com>
|
@SteveMacenski as promised, pinging now that the PR is ready for review. |
SteveMacenski
left a comment
There was a problem hiding this comment.
Good first go! Most of my comments are just asking for logging. Since we return FALSE, it would be good to clarify if "false" means it is far away or if there was an error they should be aware of to look into possibly.
nav2_behavior_tree/include/nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.hpp
Outdated
Show resolved
Hide resolved
nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.cpp
Outdated
Show resolved
Hide resolved
nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.cpp
Outdated
Show resolved
Hide resolved
nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.cpp
Outdated
Show resolved
Hide resolved
nav2_behavior_tree/include/nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.hpp
Show resolved
Hide resolved
825fdba to
9aa63e6
Compare
Signed-off-by: Jakubach <jakubach@gmail.com>
@SteveMacenski Thanks for your comments. I've made changes and added docs. Should the initial value of |
SteveMacenski
left a comment
There was a problem hiding this comment.
One formatting request and one that I think is more clear. If you're OK with them, you should be able to just hit the 'accept changes' and it should add it and we can merge once CI is green on it!
nav2_behavior_tree/plugins/condition/is_goal_nearby_condition.cpp
Outdated
Show resolved
Hide resolved
|
I think a default of 1.0 is good yes. Make sure to just update the docs as well to reflect that |
Signed-off-by: Jakubach <jakubach@gmail.com>
SteveMacenski
left a comment
There was a problem hiding this comment.
Just waiting on docs and CI.
In the future, please try to avoid force pushing. It doesn't show me the diffs then so I can just verify the 1-2 places you actually made updates. I have to review the file in entirety again since I can't see what specifically changed.
* Added IsGoalNearby BT node Signed-off-by: Jakubach <jakubach@gmail.com> * Review fixes: added logging, parametrization and small refactorization Signed-off-by: Jakubach <jakubach@gmail.com> * Change default value of proximity_threshold Signed-off-by: Jakubach <jakubach@gmail.com> --------- Signed-off-by: Jakubach <jakubach@gmail.com>
* Added IsGoalNearby BT node Signed-off-by: Jakubach <jakubach@gmail.com> * Review fixes: added logging, parametrization and small refactorization Signed-off-by: Jakubach <jakubach@gmail.com> * Change default value of proximity_threshold Signed-off-by: Jakubach <jakubach@gmail.com> --------- Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: lotusymt <mengtiy5@uci.edu>
* Added IsGoalNearby BT node Signed-off-by: Jakubach <jakubach@gmail.com> * Review fixes: added logging, parametrization and small refactorization Signed-off-by: Jakubach <jakubach@gmail.com> * Change default value of proximity_threshold Signed-off-by: Jakubach <jakubach@gmail.com> --------- Signed-off-by: Jakubach <jakubach@gmail.com>
Basic Info
Description of contribution in a few bullet points
BT Node that return if the robot is in the goal proximity
PR related to the Steve advice on robotics stack:
https://robotics.stackexchange.com/questions/112576/maneuvers-on-paths-end-point-with-navigation2-smac-lattice-planner/112577?noredirect=1#comment48615_112577
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: