Skip to content

Added IsGoalNearby BT node#5843

Merged
SteveMacenski merged 3 commits intoros-navigation:mainfrom
Jakubach:main
Jan 9, 2026
Merged

Added IsGoalNearby BT node#5843
SteveMacenski merged 3 commits intoros-navigation:mainfrom
Jakubach:main

Conversation

@Jakubach
Copy link
Contributor

@Jakubach Jakubach commented Jan 6, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses this is a refresh of pr (#4620)
Primary OS tested on (Ubuntu)
Robotic platform tested on (Gazebo simulation of custom robot)
Does this PR contain AI generated software? (Yes, tests was generated with LLM)

Description of contribution in a few bullet points

BT Node that return if the robot is in the goal proximity
PR related to the Steve advice on robotics stack:
https://robotics.stackexchange.com/questions/112576/maneuvers-on-paths-end-point-with-navigation2-smac-lattice-planner/112577?noredirect=1#comment48615_112577

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@Jakubach Jakubach mentioned this pull request Jan 6, 2026
7 tasks
@Jakubach Jakubach force-pushed the main branch 9 times, most recently from c6754fc to 8e1ffac Compare January 7, 2026 00:40
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...ree/plugins/condition/is_goal_nearby_condition.hpp 100.00% <100.00%> (ø)
...ree/plugins/condition/is_goal_nearby_condition.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jakubach Jakubach force-pushed the main branch 15 times, most recently from 56dc4ee to 0e47b00 Compare January 7, 2026 16:03
Signed-off-by: Jakubach <jakubach@gmail.com>
@Jakubach
Copy link
Contributor Author

Jakubach commented Jan 8, 2026

@SteveMacenski as promised, pinging now that the PR is ready for review.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first go! Most of my comments are just asking for logging. Since we return FALSE, it would be good to clarify if "false" means it is far away or if there was an error they should be aware of to look into possibly.

@Jakubach
Copy link
Contributor Author

Jakubach commented Jan 9, 2026

Good first go! Most of my comments are just asking for logging. Since we return FALSE, it would be good to clarify if "false" means it is far away or if there was an error they should be aware of to look into possibly.

@SteveMacenski Thanks for your comments. I've made changes and added docs. Should the initial value of proximity_threshold be as it is (3.0m) or should I decrease it to maybe 1 meter?

@Jakubach Jakubach requested a review from SteveMacenski January 9, 2026 14:40
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One formatting request and one that I think is more clear. If you're OK with them, you should be able to just hit the 'accept changes' and it should add it and we can merge once CI is green on it!

@SteveMacenski
Copy link
Member

I think a default of 1.0 is good yes. Make sure to just update the docs as well to reflect that

Signed-off-by: Jakubach <jakubach@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on docs and CI.

In the future, please try to avoid force pushing. It doesn't show me the diffs then so I can just verify the 1-2 places you actually made updates. I have to review the file in entirety again since I can't see what specifically changed.

@SteveMacenski SteveMacenski merged commit 3616a67 into ros-navigation:main Jan 9, 2026
15 of 16 checks passed
Lotusymt pushed a commit to Lotusymt/navigation2 that referenced this pull request Jan 16, 2026
* Added IsGoalNearby BT node

Signed-off-by: Jakubach <jakubach@gmail.com>

* Review fixes: added logging, parametrization and small refactorization

Signed-off-by: Jakubach <jakubach@gmail.com>

* Change default value of proximity_threshold

Signed-off-by: Jakubach <jakubach@gmail.com>

---------

Signed-off-by: Jakubach <jakubach@gmail.com>
Lotusymt pushed a commit to Lotusymt/navigation2 that referenced this pull request Jan 16, 2026
* Added IsGoalNearby BT node

Signed-off-by: Jakubach <jakubach@gmail.com>

* Review fixes: added logging, parametrization and small refactorization

Signed-off-by: Jakubach <jakubach@gmail.com>

* Change default value of proximity_threshold

Signed-off-by: Jakubach <jakubach@gmail.com>

---------

Signed-off-by: Jakubach <jakubach@gmail.com>
Signed-off-by: lotusymt <mengtiy5@uci.edu>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
* Added IsGoalNearby BT node

Signed-off-by: Jakubach <jakubach@gmail.com>

* Review fixes: added logging, parametrization and small refactorization

Signed-off-by: Jakubach <jakubach@gmail.com>

* Change default value of proximity_threshold

Signed-off-by: Jakubach <jakubach@gmail.com>

---------

Signed-off-by: Jakubach <jakubach@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants