improve logging with more verbosity in SimpleChargingDock#5824
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Jan 20, 2026
Merged
improve logging with more verbosity in SimpleChargingDock#5824SteveMacenski merged 1 commit intoros-navigation:mainfrom
SteveMacenski merged 1 commit intoros-navigation:mainfrom
Conversation
mini-1235
requested changes
Dec 27, 2025
Collaborator
There was a problem hiding this comment.
Could you please fix the linting and sign with DCO?
opennav_docking.uncrustify
Diff with 7 lines
--- src/simple_charging_dock.cpp
+++ src/simple_charging_dock.cpp.uncrustify
@@ -259,2 +259,2 @@
- detected.header.stamp.sec + detected.header.stamp.nanosec* 1e-9
- ));
+ detected.header.stamp.sec + detected.header.stamp.nanosec * 1e-9
+ ));
Member
|
@HannesBachter across the 3 PRs and then I can merge all 3! Cross linking: |
Collaborator
|
@HannesBachter any updates? |
HannesBachter
force-pushed
the
fix/verbose_logging
branch
from
83773de to
3a96b04
Compare
Contributor
Author
|
Sorry for the delay, updated to align with |
HannesBachter
force-pushed
the
fix/verbose_logging
branch
2 times, most recently
from
7d454ef to
68e102e
Compare
Codecov Report❌ Patch coverage is
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mini-1235
reviewed
Jan 19, 2026
| RCLCPP_WARN(node_->get_logger(), "Failed to transform detected dock pose"); | ||
| RCLCPP_WARN( | ||
| node_->get_logger(), "Failed to transform detected dock pose: " | ||
| "cannot transform %s to %s at time %2.2f)s", |
Collaborator
There was a problem hiding this comment.
There's an extra ) in this line, I think this should be removed, right?
Contributor
Author
There was a problem hiding this comment.
Yes, good catch - I'm sorry I missed that 🙈
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
See @mini-1235 's review. Update for the 3 PRs and I can merge!
Signed-off-by: Hannes Bachter <hannes.bachter@neura-robotics.com>
HannesBachter
force-pushed
the
fix/verbose_logging
branch
from
68e102e to
d17c857
Compare
mini-1235
approved these changes
Jan 20, 2026
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
…tion#5824) Signed-off-by: Hannes Bachter <hannes.bachter@neura-robotics.com> Co-authored-by: Hannes Bachter <hannes.bachter@neura-robotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
tfframe availabletfframe availableFuture work that may be required in bullet points
For Maintainers:
backport-*.