Humble backport fixes#5371
Conversation
…igation#3605) * CI test fixing for BT.CPP (paired with BehaviorTree.CPP/579) * lint * fixing smoother unit test failures Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
|
@jncfa one small error from linting:
and that does resolve a couple of the failures! Thank you! There are still a couple left but I'll take any incremental improvements I can get :-) |
Signed-off-by: jncfa <20467009+jncfa@users.noreply.github.com>
Sounds good! :) I looked into a few of the test failures (the collision monitor and MPPI ones in particular) but didn't manage to fix them yet, so I would rather send a PR to address those separately Should I create* a follow-up issue to track those failing tests? |
|
I think you can just comment back on the original ticket! Will merge this one CI finishes 😄 |
|
It's interesting that on CircleCI there are quite a lot less tests failing compared to my local devcontainer setup 🤔 https://app.circleci.com/pipelines/github/ros-navigation/navigation2/15532/workflows/92450c42-9041-427f-91df-165a0eeb6a9c/jobs/45267/tests |
Basic Info
Description of contribution in a few bullet points
Backports bug fixes from main to humble:
Also fixes the devcontainer setup for humble (as I used it for testing and ran into those issues).
Description of documentation updates required from your changes
Description of how this change was tested
Ran
colcon test, which fixes the some of the test issues reported above, however there are still other unrelated tests failing:Future work that may be required in bullet points
For Maintainers:
backport-*.