Create a Humble distribution compatible version of the main (Rolling)…#5017
Create a Humble distribution compatible version of the main (Rolling)…#5017MaciejGroszyk wants to merge 22 commits intoros-navigation:humble_mainfrom MaciejGroszyk:humble_main
Conversation
… branch issue Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
@MaciejGroszyk, all pull requests must be targeted towards the |
|
Huge thanks for taking this on, that's a big help to maintainers!
This program's cmake should be commented out so that it is not compiled. This is not possible to be used with Humble
LGTM
Nav2 had a version of that in our nav2_util that I removed once the rclcpp version was merged. Add this to nav2_util again from rclcpp and reuse it! 😄
Please open that PR against Humble to add to
Is that equal? I don't recall that API change in rclcpp.
Why not? R_L doesn't have the LL to map service in Humble? |
…ter_values added back to nav2_util, clean up comments in CMakeLists.txt Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
The PR to geometry_msgs is ready ros2/common_interfaces#273. |
SteveMacenski
left a comment
There was a problem hiding this comment.
Massive thanks, this is really helpful for many users!
I think beyond the comments above there are 2 final bits:
- Can you run
colcon testand make sure everything is running properly while onHumble? Minor linting issues I don't care about for this case, but any functional issues are important - Can you run the basic nav2 demos in
nav2_bringupand make sure those work?
Thanks!
PS: I expect CI build to fail since that's based on rolling and the APIs you updated here support Humble :-)
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
I think the functional / testing are all that's left, except for the R_L questions on the WPF |
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
… fix error: too many argument nav2_util::ServiceClient Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
A FromLL service is in Humble. Error is related to casting nav2_util::LifecycleNode ptr to rclcpp::Node ptr. I just use std::dynamic_pointer_cast to handle that. Is it ok? Colcon test-result is: Summary: 3866 tests, 102 errors, 261 failures, 815 skipped ros2 launch nav2_bringup tb3_simulation_launch.py returns: |
|
Sounds like there are alot of issues - can you look into them? It may be
That may not be available in Humble and we need to use another action type (I think it was just renamed or something) |
…n with PythonExpression Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
SteveMacenski
left a comment
There was a problem hiding this comment.
How did your testing with colcon and functional testing go? Any other issues or failures?
| from launch.substitutions import LaunchConfiguration, PythonExpression | ||
| from launch_ros.actions import Node | ||
| from launch_ros.actions import PushROSNamespace | ||
| # from launch_ros.actions import PushROSNamespace |
There was a problem hiding this comment.
I think the name just changed from PushRosNamspace to PushROSNamespace. I think can use the former
Summary: 4049 tests, 42 errors, 108 failures, 815 skipped tb3_simulation_launch.py and tb4_simulation. ros2 launch nav2_bringup cloned_multi_tb3_simulation_launch.py
|
|
Ah, ForEach is not in Humble, I think the multi-robot style of launch files currently in Humble needs to be used in this case |
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
Let me know when I should take a look again! :-) |
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
Hi, progress is going really slow. Right now it is Summary: 4175 tests, 35 errors, 196 failures, 815 skipped. After launching tb3_loopback_simulation.launch.py I have a issue with: In parallel I tried to create a devcontainer and I am struggling with: CMake Error at /opt/ros/humble/share/ament_cmake_gtest/cmake/ament_cmake_gtest-extras.cmake:89 (set_target_properties): |
|
35 failures from 108? I think that's pretty fast in my opinion! 😄
Are you only seeing it with that one launch file (not TB4, not with Gazebo)? Usually means something along the lines that the odometry isn't being published, usually because the simulator isn't up yet. Its OK if that happens for a short while while the system is coming up, but if its indefinite then that's an issue.
That's itneresting. Its trying to find I checked and |
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
…iRobotPose to fix launch nav2_bringup unique_multi_tb3_simulation_launch.py Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
|
colcon test --packages-skip nav2_minimal_tb3_sim nav2_minimal_tb4_description nav2_minimal_tb4_sim I reverted commit 2cd166f without parameters.key >>-v32, return ParseMultiRobotPose to fix launch nav2_bringup unique_multi_tb3_simulation_launch.py |
Makes sense! Any other questions I can help answer? What are the remaining error's nature? |
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Signed-off-by: MaciejGroszyk <maciekgroszyk12@gmail.com>
Remaining errors are only in nav2_system_test. |
|
Those are usually simulator not runnign related. You probably want to revert the modern Gazebo PR and use Gazebo Classic for Humble in these |
|
@MaciejGroszyk hey, just checking back in, how's it going? :-) |
|
PR superseded! Should be merged in soon! |
… branch issue
There are still few unsolved issues:
TransformListener::subscription_callback(msg, is_static) is private within this context. I moved it locally to public methods, like in jazzy and rolling.spin_somecreate_wall_timer.211 | std::shared_ptr<nav2_util::LifecycleNode>>> from_ll_to_map_client_; '. Can't fix that. I commented it so whole package is building successfully with above changes.
Basic Info
Description of contribution in a few bullet points
Create a Humble distribution compatible version of the main (Rolling) branch issue PR.
Description of documentation updates required from your changes
target_link_librarieschanged toament_target_dependenciesin CMakeLists.txt.service QoS resolved with get_rmw_qos_profile
Description of how this change was tested
It was successfully built with
colcon build --symlink-installcommand.Future work that may be required in bullet points
Refer to unsolved issues described at the beginning.
For Maintainers: